Skip to content

SAB212 - Start Page with new cards - #39

Merged
SimonR-Education merged 5 commits into
mainfrom
feature/SAB212-Start
Aug 21, 2026
Merged

SAB212 - Start Page with new cards#39
SimonR-Education merged 5 commits into
mainfrom
feature/SAB212-Start

Conversation

@SimonR-Education

@SimonR-Education SimonR-Education commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  • The Start page now has the cards with the correct text
  • Tests for Logout and Login Updated
image

…ncluding updated routing, views, controllers, integration tests, and styling adjustments.
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Test Results

47 tests  ±0   47 ✅ ±0   22s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 4 files   ±0    0 ❌ ±0 

Results for commit 7046bbb. ± Comparison against base commit 207a5c4.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
SchoolAccount.IntegrationTests.Features.Start.HomeControllerTests ‑ Ensure_that_the_start_controller_returns_a_successful_result
SchoolAccount.IntegrationTests.Features.Start.StartControllerTests ‑ Ensure_that_the_start_controller_returns_a_successful_result

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Summary

Summary
Generated on: 08/21/2026 - 12:53:31
Parser: MultiReport (4x Cobertura)
Assemblies: 4
Classes: 36
Files: 30
Line coverage: 81.7% (292 of 357)
Covered lines: 292
Uncovered lines: 65
Coverable lines: 357
Total lines: 1033
Branch coverage: 71.1% (84 of 118)
Covered branches: 84
Total branches: 118
Method coverage: Feature is only available for sponsors
Tag: 195_32483971672

Coverage

SchoolAccount.Application - 61.7%
Name Line Branch
SchoolAccount.Application 61.7% 77.2%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandB
aseHandler
0% 0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandB
aseHandler
0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandH
andler<TCommand, TResponse>
0% 0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandH
andler<TCommand, TResponse>
0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.QueryHan
dler<TQuery, TResponse>
70% 50%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.QueryHan
dler<TQuery, TResponse>
100%
SchoolAccount.Application.DependencyInjection 100% 100%
SchoolAccount.Application.Greetings.GetTimeSpecificHello.GetTimeSpecificHel
loHandler
100% 100%
SchoolAccount.Application.Greetings.GetTimeSpecificHello.GetTimeSpecificHel
loQuery
100%
SchoolAccount.Application.Greetings.GetTimeSpecificHello.GetTimeSpecificHel
loResponse
100%
SchoolAccount.Infrastructure - 100%
Name Line Branch
SchoolAccount.Infrastructure 100% ****
SchoolAccount.Infrastructure.DependencyInjection 100%
SchoolAccount.Infrastructure.Time.DateTimeProvider 100%
SchoolAccount.SharedKernel - 71%
Name Line Branch
SchoolAccount.SharedKernel 71% 37.5%
SchoolAccount.SharedKernel.Error 73.3%
SchoolAccount.SharedKernel.Result 63.6% 50%
SchoolAccount.SharedKernel.Result 90% 50%
SchoolAccount.SharedKernel.ValidationError 0% 0%
SchoolAccount.Web.Mvc - 90.1%
Name Line Branch
SchoolAccount.Web.Mvc 90.1% 76.2%
AspNetCoreGeneratedDocument.Features__ViewStart 100%
AspNetCoreGeneratedDocument.Features_Dashboard_Dashboard 100%
AspNetCoreGeneratedDocument.Features_Error_Error 100% 75%
AspNetCoreGeneratedDocument.Features_Shared__Layout 100% 100%
AspNetCoreGeneratedDocument.Features_Start_Start 100%
Program 95.2% 75%
SchoolAccount.Web.Mvc.Authentication.Extensions.ServiceCollectionExtensions 89% 90%
SchoolAccount.Web.Mvc.Authentication.Handlers.OpenIdConnectEventHandlers 100% 83.3%
SchoolAccount.Web.Mvc.Authentication.UserContext 100% 75%
SchoolAccount.Web.Mvc.DependencyInjection 94.7% 83.3%
SchoolAccount.Web.Mvc.Extensions.ConfigurationExtensions 0% 0%
SchoolAccount.Web.Mvc.Features.Accounts.AccountController 100% 87.5%
SchoolAccount.Web.Mvc.Features.Dashboard.DashboardController 90% 50%
SchoolAccount.Web.Mvc.Features.Dashboard.DashboardViewModel 100%
SchoolAccount.Web.Mvc.Features.Error.ErrorController 100%
SchoolAccount.Web.Mvc.Features.Error.ErrorViewModel 100% 100%
SchoolAccount.Web.Mvc.Features.Header.HeaderContentProvider 100% 100%
SchoolAccount.Web.Mvc.Features.Start.StartController 100%
SchoolAccount.Web.Mvc.Infrastructure.FeatureConvention 100% 75%
SchoolAccount.Web.Mvc.Infrastructure.FeatureViewLocationExpander 94.1% 70%

Comment thread src/SchoolAccount.Web.Mvc/Features/Start/StartController.cs Outdated

@markysoft markysoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonR-Education
SimonR-Education merged commit 46b3373 into main Aug 21, 2026
2 checks passed
@SimonR-Education
SimonR-Education deleted the feature/SAB212-Start branch August 21, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants