combine.lua when 'here' is specified, try harder to determine the target stockpile. #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a stockpile is not selected, try finding it using these: * If an item is selected, find the stockpile (if any) that it is in. * If a dwarfmode/ViewSheets/ITEM_LIST is active in the UI, find the stockpile (if any) of the tile being viewed.
Note: I did not try to rebuild the documentation .txt and .html files.
ab9rf
reviewed
Dec 4, 2025
this delta removes two inline comments which uselessly documented a function parameter. minimal testing -- one minute total to test the four ways that stockpiles can be selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combine.luaThis enhances theherecommand-line parameter.If a stockpile is not selected, try finding it using these alternate methods:
dwarfmode/ViewSheets/ITEM_LISTis active in the UI (permatchFocusString()), find the stockpile (if any) of the first item in that item list.Note: I edited the documentation
.rstfile, but did not test creating the actual documentation.Side note: It is technically possible to have items in the same DF item list located in different tiles, and in different buildings, and probably different containers (not tested), but I do not believe the game ever shows such item lists. This state can be caused by DFHack by manipulating items' locations while the DF item list is open. This does not break the DF item list but could result in the combine script having unexpected behavior.