-
Notifications
You must be signed in to change notification settings - Fork 57
Split SEGMENTSIZE_XY and add an autosize config #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
realSquidCoder
wants to merge
33
commits into
DFHack:master
Choose a base branch
from
SquidCoderIndustries:squid-segmentsize-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
b3aa1e5
Split SEGMENTSIZE_XY and add an autosize conifg
realSquidCoder 6c8bdcc
Merge branch 'DFHack:master' into squid-segmentsize-changes
realSquidCoder 166e8c8
change how we do autosizing
realSquidCoder 8914fae
forgot cmath and the renaming of vars
realSquidCoder 2e49f32
Merge branch 'DFHack:master' into squid-segmentsize-changes
realSquidCoder 0f3a8e0
remove use of std::min
realSquidCoder 59b0f47
Resolve code review things and add keybinds
realSquidCoder 234a2fd
cleaned autosizer
realSquidCoder 5904d00
Update changelog.txt
realSquidCoder f0c0520
Forgot cmath
realSquidCoder c23aa74
fixing up autosizer
realSquidCoder 5291b38
Code review changes
realSquidCoder 260a255
Revert keys and add my name
realSquidCoder ed6d416
Fix typo in keys
realSquidCoder 7ad9b31
cleaned up use of getAutoSegmentSize
realSquidCoder 7d3e3b9
Update docs/changelog.txt
realSquidCoder eeb3305
remove my name. (belongs in a new PR with Rome added too!)
realSquidCoder e74be9f
Apply suggestions from code review
realSquidCoder 833708c
Merge branch 'DFHack:master' into squid-segmentsize-changes
realSquidCoder 949ac83
Merge files
realSquidCoder 135e2d8
Merge remote-tracking branch 'upstream/master' into squid-segmentsize…
realSquidCoder ce4ff34
missed a few lines
realSquidCoder 1a88f44
Merge
realSquidCoder e5c4ca5
Merge branch 'master' into squid-segmentsize-changes
realSquidCoder 1aceaaa
Merge branch 'master' into squid-segmentsize-changes
realSquidCoder ab3fb1f
Merge branch 'master' into squid-segmentsize-changes
realSquidCoder f5b81e3
Remember to do an initial resize.
realSquidCoder 1dd470e
Merge branch 'master' into squid-segmentsize-changes
realSquidCoder 07b545f
Use auto bc we made it for a reason
realSquidCoder 4b9957a
Merge branch 'master' into squid-segmentsize-changes
realSquidCoder 8456049
Merge branch 'master' into squid-segmentsize-changes
myk002 571d3dd
Merge remote-tracking branch 'upstream/master' into squid-segmentsize…
realSquidCoder 1d96ef9
Merge branch 'master' into squid-segmentsize-changes
myk002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,10 @@ KEYBINDINGS: | |
| [RESET_VIEW_OFFSET:KEY_Z] | ||
| [DECR_SEGMENT_Z:KEY_1] | ||
| [INCR_SEGMENT_Z:KEY_2] | ||
| [DECR_SEGMENT_X:KEYPAD_4] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wherever this keybinding is handled, it's allowing the value to go negative. Same for DECR_SEGMENT_Y
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| [INCR_SEGMENT_X:KEYPAD_6] | ||
| [DECR_SEGMENT_Y:KEYPAD_2] | ||
| [INCR_SEGMENT_Y:KEYPAD_8] | ||
realSquidCoder marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| [TOGGLE_SINGLE_LAYER:KEY_S] | ||
| [TOGGLE_SHADE_HIDDEN_TILES:KEY_B] | ||
| [TOGGLE_SHOW_HIDDEN_TILES:KEY_H] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.