Skip to content

Remove Resource Download Page and fix UI on navbar #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

prpjzz
Copy link
Contributor

@prpjzz prpjzz commented May 8, 2025

Description

#2680

Checklist

  • The target PR branch is develop branch

@Copilot Copilot AI review requested due to automatic review settings May 8, 2025 07:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the resource download page from the LaunchGamePage and adjusts the navbar dimensions in MainView to improve the UI aesthetics.

  • Removed the PivotItem and related UI components for the resource download page in LaunchGamePage.xaml
  • Updated CompactPaneLength and OpenPaneLength values in MainView.xaml to better reflect the desired design

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Page/LaunchGamePage.xaml Removed the resource download page UI elements to deprecate this feature
src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/MainView.xaml Adjusted the navigation pane dimensions to enhance the navbar layout
Comments suppressed due to low confidence (3)

src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Page/LaunchGamePage.xaml:697

  • [nitpick] Ensure that any bindings, converters, or dependencies exclusively tied to the removed resource download elements are cleaned up to maintain code clarity.
<PivotItem Header="{shuxm:ResourceString Name=ViewPageLaunchGameResourceHeader}">

src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/MainView.xaml:54

  • [nitpick] Verify that the new CompactPaneLength provides a consistent user experience across different screen sizes, as this value may affect the overall layout.
CompactPaneLength="45"

src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/MainView.xaml:58

  • [nitpick] Confirm that the new OpenPaneLength value is tested across various devices and window sizes to ensure optimal navigation pane rendering.
OpenPaneLength="205"

@Lightczx Lightczx merged commit b0d312a into DGP-Studio:develop May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants