Add compute costs to challenge stats (#2536)

Author: amickan

app/grandchallenge/pages/templates/pages/challenge_statistics.html

@@ -1,6 +1,7 @@
 {% extends "base.html" %}
 {% load url %}
 {% load naturaldelta %}
+{% load dict_lookup %}
 
 {% block title %}
         Statistics
@@ -22,29 +23,20 @@
 {% block content %}
     <h3 class="mb-3">Challenge statistics</h3>
     {% if average_job_durations %}
-        <div class="table-responsive">
-            <table class="table table-hover table-sm w-50">
-                <tbody>
-                    {% for phase, durations in average_job_durations.items %}
-                        <tr>
-                            <td>
-                                Average algorithm job duration for {{ phase }}:
-                            </td>
-                             <td>
-                                {{ durations.average_duration|naturaldelta }}
-                            </td>
-                        </tr>
-                        <tr>
-                            <td>
-                                Total algorithm job duration for {{ phase }}:
-                            </td>
-                             <td>
-                                {{ durations.total_duration|naturaldelta }}
-                            </td>
-                        </tr>
-                    {% endfor %}
-                </tbody>
-            </table>
+        <div class="row equal-height mx-n2">
+            {% for phase, durations in average_job_durations.items %}
+                <div class="card m-1">
+                    <div class="card-header">{{ phase }}</div>
+                    <div class="card-body">
+                        <ul>
+                            <li>Average algorithm job duration: {{ durations.average_duration|naturaldelta }}</li>
+                            <li>Total duration of all jobs for this phase: {{ durations.total_duration|naturaldelta }}</li>
+                            <li>Number of archive items: {% get_dict_values num_archive_items phase as item_count %} {{ item_count }}</li>
+                            <li>Average compute cost per algorithm job: {% get_dict_values compute_costs phase as cost %} {% if cost %}{{ cost }} €{% else %} NA {% endif %}</li>
+                        </ul>
+                    </div>
+                </div>
+            {% endfor %}
         </div>
     {% else %}
         No statistics to show for this challenge.

app/grandchallenge/pages/views.py

@@ -1,6 +1,6 @@
 from django.contrib import messages
 from django.contrib.auth.mixins import UserPassesTestMixin
-from django.db.models import Q
+from django.db.models import Count, Q
 from django.http import Http404
 from django.views.generic import (
     CreateView,
@@ -15,8 +15,8 @@
     PermissionRequiredMixin as ObjectPermissionRequiredMixin,
 )
 
+from config import settings
 from grandchallenge.algorithms.models import Job
-from grandchallenge.core.mixins import UserIsStaffMixin
 from grandchallenge.evaluation.utils import SubmissionKindChoices
 from grandchallenge.pages.forms import PageCreateForm, PageUpdateForm
 from grandchallenge.pages.models import Page
@@ -161,24 +161,50 @@ def get_average_job_duration_for_phase(phase):
     return duration_dict
 
 
-class ChallengeStatistics(LoginRequiredMixin, UserIsStaffMixin, TemplateView):
+class ChallengeStatistics(
+    LoginRequiredMixin, UserPassesTestMixin, TemplateView
+):
     template_name = "pages/challenge_statistics.html"
 
     def get_context_data(self, **kwargs):
         context = super().get_context_data()
-        phases = self.request.challenge.phase_set.filter(
-            submission_kind=SubmissionKindChoices.ALGORITHM
-        ).all()
+        phases = (
+            self.request.challenge.phase_set.filter(
+                submission_kind=SubmissionKindChoices.ALGORITHM
+            )
+            .annotate(archive_item_count=Count("archive__items"))
+            .all()
+        )
         duration_dict = {}
+        archive_items_dict = {}
+        compute_costs_dict = {}
         for phase in phases:
-            duration_dict[phase.title] = get_average_job_duration_for_phase(
-                phase=phase
-            )
+            avg_duration = get_average_job_duration_for_phase(phase=phase)
+            duration_dict[phase.title] = avg_duration
+            archive_items_dict[phase.title] = phase.archive_item_count
+            try:
+                compute_costs_dict[phase.title] = round(
+                    phase.archive_item_count
+                    * avg_duration["average_duration"]
+                    * settings.CHALLENGES_COMPUTE_COST_CENTS_PER_HOUR
+                    / 60
+                    / 100,
+                    ndigits=2,
+                )
+            except TypeError:
+                compute_costs_dict[phase.title] = None
 
         context.update(
             {
                 "average_job_durations": duration_dict,
+                "num_archive_items": archive_items_dict,
+                "compute_costs": compute_costs_dict,
             }
         )
 
         return context
+
+    def test_func(self):
+        return self.request.user.is_staff or self.request.user.has_perm(
+            "challenges.view_challengerequest"
+        )

app/tests/pages_tests/test_pages.py

@@ -4,6 +4,7 @@
 import pytest
 from django.db.models import BLANK_CHOICE_DASH
 from django.utils.timezone import now
+from guardian.shortcuts import assign_perm
 
 from grandchallenge.components.models import (
     ComponentInterface,
@@ -324,8 +325,9 @@ def test_create_page_with_same_title(client, two_challenge_sets):
 def test_challenge_statistics_page_permissions(client):
     challenge = ChallengeFactory()
     staff = UserFactory(is_staff=True)
-    admin, user = UserFactory.create_batch(2)
+    admin, reviewer, user = UserFactory.create_batch(3)
     challenge.add_admin(admin)
+    assign_perm("challenges.view_challengerequest", reviewer)
 
     response = get_view_for_user(
         viewname="pages:statistics",
@@ -343,6 +345,14 @@ def test_challenge_statistics_page_permissions(client):
     )
     response.status_code = 404
 
+    response = get_view_for_user(
+        viewname="pages:statistics",
+        client=client,
+        user=reviewer,
+        challenge=challenge,
+    )
+    response.status_code = 200
+
     response = get_view_for_user(
         viewname="pages:statistics",
         client=client,