Remove cached property, for now

Author: chrisvanrun

app/grandchallenge/challenges/models.py

@@ -938,26 +938,16 @@ def has_paid_prepaid_invoice(self):
             payment_status=PaymentStatusChoices.PAID,
         ).exists()
 
-    @cached_property
-    def compute_costs_balance_euros_millicents(self):
-        return self._get_compute_costs_balance_euros_millicents(
-            invoices=self.invoices.all()
-        )
+    @property
+    def active_invoice(self):
+        invoices = self.invoices.order_by("expires_on", "created")
 
-    def _get_compute_costs_balance_euros_millicents(self, *, invoices):
-        return sum(
+        total_balance = sum(
             invoice.compute_costs_balance_euros_millicents
             for invoice in invoices
         )
 
-    @property
-    def active_invoice(self):
-        invoices = self.invoices.order_by("expires_on", "created")
-
-        if (
-            self._get_compute_costs_balance_euros_millicents(invoices=invoices)
-            <= 0
-        ):
+        if total_balance <= 0:
             raise InsufficientBudgetError
 
         for invoice in invoices: