Propagate linked task to add_civ_to_object to retain original flow

The linked task should only run if the change was successful

Author: koopmant

app/grandchallenge/components/tasks.py

@@ -1249,7 +1249,7 @@ def get_object(*, app_label, model_name, object_pk):
 
 
 def add_civ_to_object(
-    *, civ, obj, current_value, error_handler, interface, user
+    *, civ, obj, current_value, error_handler, interface, user, linked_task
 ):
     from grandchallenge.algorithms.models import Job
 
@@ -1269,6 +1269,12 @@ def add_civ_to_object(
             logger.error(e, exc_info=True)
             return
 
+    if linked_task is not None:
+        logger.info("Scheduling linked task")
+        on_commit(signature(linked_task).apply_async)
+    else:
+        logger.info("No linked task, task complete")
+
 
 def add_image_to_object(
     *,
@@ -1277,6 +1283,7 @@ def add_image_to_object(
     interface,
     error_handler,
     user,
+    linked_task,
 ):
     from grandchallenge.components.models import ComponentInterfaceValue
 
@@ -1315,6 +1322,7 @@ def add_image_to_object(
         error_handler=error_handler,
         interface=interface,
         user=user,
+        linked_task=linked_task,
     )
 
 
@@ -1365,14 +1373,9 @@ def add_panimg_image_to_object(
         interface=interface,
         error_handler=error_handler,
         user=upload_session.creator,
+        linked_task=linked_task,
     )
 
-    if linked_task is not None:
-        logger.info("Scheduling linked task")
-        on_commit(signature(linked_task).apply_async)
-    else:
-        logger.info("No linked task, task complete")
-
 
 @acks_late_micro_short_task(
     retry_on=(LockNotAcquiredException,), delayed_retry=False
@@ -1416,14 +1419,9 @@ def add_dicom_image_set_to_object(
         interface=interface,
         error_handler=error_handler,
         user=dicom_image_set.dicom_image_set_upload.creator,
+        linked_task=linked_task,
     )
 
-    if linked_task is not None:
-        logger.info("Scheduling linked task")
-        on_commit(signature(linked_task).apply_async)
-    else:
-        logger.info("No linked task, task complete")
-
 
 @acks_late_micro_short_task(
     retry_on=(LockNotAcquiredException,), delayed_retry=False
@@ -1488,14 +1486,9 @@ def add_file_to_object(
         error_handler=error_handler,
         interface=interface,
         user=user_upload.creator,
+        linked_task=linked_task,
     )
 
-    if linked_task is not None:
-        logger.info("Scheduling linked task")
-        on_commit(signature(linked_task).apply_async)
-    else:
-        logger.info("No linked task, task complete")
-
 
 @acks_late_2xlarge_task(retry_on=(LockNotAcquiredException,))
 @transaction.atomic