Remove creator must be verified option (#4290)

Our challenges now require an algorithm phase so being verified is not
optional.

Author: jmsmkn

app/grandchallenge/challenges/models.py

@@ -782,13 +782,6 @@ def remove_admin(self, user):
         user.groups.remove(self.admins_group)
         unfollow(user=user, obj=self.discussion_forum, send_action=False)
 
-    @cached_property
-    def should_show_verification_warning(self):
-        for phase in self.visible_phases:
-            if phase.creator_must_be_verified:
-                return True
-        return False
-
     @cached_property
     def status(self) -> str:
         phase_status = {phase.status for phase in self.visible_phases}

app/grandchallenge/evaluation/forms.py

@@ -10,7 +10,6 @@
 from django.db.models import BooleanField, Case, Exists, OuterRef, When
 from django.db.transaction import on_commit
 from django.forms import (
-    CheckboxInput,
     CheckboxSelectMultiple,
     Form,
     HiddenInput,
@@ -63,7 +62,6 @@
     "submissions_open_at",
     "submissions_close_at",
     "submission_page_markdown",
-    "creator_must_be_verified",
     "submissions_limit_per_user_per_period",
     "submission_limit_period",
     "allow_submission_comments",
@@ -192,9 +190,6 @@ def __init__(self, *args, **kwargs):
                     *algorithm_setting_options,
                 )
             )
-            self.fields["creator_must_be_verified"].widget = CheckboxInput(
-                attrs={"checked": True}
-            )
 
     class Meta:
         model = Phase
@@ -568,7 +563,7 @@ def clean_creator(self):
         except ObjectDoesNotExist:
             user_is_verified = False
 
-        if self._phase.creator_must_be_verified and not user_is_verified:
+        if not user_is_verified:
             error_message = format_html(
                 "You must verify your account before you can make a "
                 "submission to this phase. Please "

app/grandchallenge/evaluation/migrations/0096_remove_phase_creator_must_be_verified.py

@@ -0,0 +1,20 @@
+# Generated by Django 4.2.23 on 2025-09-05 11:26
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        (
+            "evaluation",
+            "0095_remove_phase_evaluation__challen_c9ad78_idx_and_more",
+        ),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="phase",
+            name="creator_must_be_verified",
+        ),
+    ]

app/grandchallenge/evaluation/models.py

@@ -376,13 +376,6 @@ class Phase(FieldChangeMixin, HangingProtocolMixin, UUIDModel):
         default=ALL,
         help_text=("Which results should be displayed on the leaderboard?"),
     )
-    creator_must_be_verified = models.BooleanField(
-        default=False,
-        help_text=(
-            "If True, only participants with verified accounts can make "
-            "submissions to this phase"
-        ),
-    )
     submission_kind = models.PositiveSmallIntegerField(
         default=SubmissionKindChoices.CSV,
         choices=SubmissionKindChoices.choices,
@@ -797,11 +790,6 @@ def _clean_submission_kind(self):
 
     def _clean_algorithm_submission_settings(self):
         if self.submission_kind == SubmissionKindChoices.ALGORITHM:
-            if not self.creator_must_be_verified:
-                raise ValidationError(
-                    "For phases that take an algorithm as submission input, "
-                    "the creator_must_be_verified box needs to be checked."
-                )
             if (
                 self.submissions_limit_per_user_per_period > 0
                 and not self.external_evaluation

app/grandchallenge/evaluation/templates/evaluation/submission_form.html

@@ -26,9 +26,7 @@
 {% endblock %}
 
 {% block content %}
-    {% if phase.creator_must_be_verified %}
-        {% include "challenges/partials/participant_verification_warning.html" %}
-    {% endif %}
+    {% include "challenges/partials/participant_verification_warning.html" %}
 
     <h2>{{ phase.title }} Submission</h2>
 

app/grandchallenge/evaluation/views/__init__.py

@@ -1177,7 +1177,6 @@ def turn_phase_into_algorithm_phase(
         )
         phase.archive = archive
         phase.submission_kind = phase.SubmissionKindChoices.ALGORITHM
-        phase.creator_must_be_verified = True
         phase.save()
 
 

app/grandchallenge/pages/templates/pages/page_detail.html

@@ -55,7 +55,7 @@
 
 {% block content %}
     <div class="ml-lg-3">
-        {% if challenge.should_show_verification_warning and user_is_participant %}
+        {% if user_is_participant %}
             {% include "challenges/partials/participant_verification_warning.html" %}
         {% endif %}
 

app/tests/evaluation_tests/test_forms.py

@@ -415,6 +415,7 @@ def test_algorithm_no_permission(self):
 
     def test_algorithm_with_permission(self):
         user = UserFactory()
+        VerificationFactory(user=user, is_verified=True)
         alg = AlgorithmFactory()
         alg.add_editor(user=user)
         ci1 = ComponentInterfaceFactory()
@@ -473,6 +474,7 @@ def test_algorithm_with_permission(self):
 
     def test_algorithm_image_and_model_set(self):
         user = UserFactory()
+        VerificationFactory(user=user, is_verified=True)
         alg = AlgorithmFactory()
         alg.add_editor(user=user)
         ci1 = ComponentInterfaceFactory()
@@ -535,7 +537,7 @@ def test_user_no_verification(self):
 
         form = SubmissionForm(
             user=user,
-            phase=PhaseFactory(creator_must_be_verified=True),
+            phase=PhaseFactory(),
             data={"creator": user},
         )
 
@@ -552,7 +554,6 @@ def test_user_with_verification(self, is_verified):
         VerificationFactory(user=user, is_verified=is_verified)
 
         phase = PhaseFactory(
-            creator_must_be_verified=True,
             submissions_limit_per_user_per_period=10,
         )
         InvoiceFactory(
@@ -574,6 +575,7 @@ def test_user_with_verification(self, is_verified):
 
     def test_no_valid_archive_items(self):
         user = UserFactory()
+        VerificationFactory(user=user, is_verified=True)
         p_pred = PhaseFactory(
             submission_kind=SubmissionKindChoices.CSV,
             submissions_limit_per_user_per_period=10,
@@ -777,6 +779,7 @@ def test_eval_exists_for_image_and_model(
         self, model_active, submission_with_model_present, form_is_valid
     ):
         user = UserFactory()
+        VerificationFactory(user=user, is_verified=True)
         alg = AlgorithmFactory()
         alg.add_editor(user=user)
         ci1 = ComponentInterfaceFactory()

app/tests/evaluation_tests/test_models.py

@@ -998,7 +998,6 @@ def test_email_sent_to_editors_when_permissions_enabled():
 @pytest.mark.django_db
 def test_give_algorithm_editors_job_view_permissions_only_for_algorithm_phase():
     phase = PhaseFactory(
-        creator_must_be_verified=True,
         submission_kind=Phase.SubmissionKindChoices.CSV,
         give_algorithm_editors_job_view_permissions=False,
     )
@@ -1071,9 +1070,7 @@ def test_parent_phase_choices_no_circular_dependency():
 
 @pytest.mark.django_db
 def test_clean_parent_phase():
-    p1, p2, p3, p4 = PhaseFactory.create_batch(
-        4, challenge=ChallengeFactory(), creator_must_be_verified=True
-    )
+    p1, p2, p3, p4 = PhaseFactory.create_batch(4, challenge=ChallengeFactory())
     ci1, ci2 = ComponentInterfaceFactory.create_batch(2)
     interface = AlgorithmInterfaceFactory(inputs=[ci1], outputs=[ci2])
 

app/tests/evaluation_tests/test_tasks.py

@@ -48,6 +48,7 @@
     create_upload_from_file,
 )
 from tests.utils import get_view_for_user, recurse_callbacks
+from tests.verification_tests.factories import VerificationFactory
 
 
 @pytest.mark.django_db
@@ -85,6 +86,7 @@ def test_submission_evaluation(
     )
 
     participant = UserFactory()
+    VerificationFactory(user=participant, is_verified=True)
     phase.challenge.add_participant(user=participant)
 
     user_upload = create_upload_from_file(
@@ -581,6 +583,7 @@ def test_non_zip_submission_failure(
     )
 
     participant = UserFactory()
+    VerificationFactory(user=participant, is_verified=True)
     phase.challenge.add_participant(user=participant)
 
     user_upload = create_upload_from_file(
@@ -652,6 +655,7 @@ def test_evaluation_notifications(
     )
 
     participant = UserFactory()
+    VerificationFactory(user=participant, is_verified=True)
     phase.challenge.add_participant(user=participant)
 
     user_upload = create_upload_from_file(
@@ -868,6 +872,7 @@ def test_evaluation_time_limit_set(
     )
 
     participant = UserFactory()
+    VerificationFactory(user=participant, is_verified=True)
     phase.challenge.add_participant(user=participant)
 
     user_upload = create_completed_upload(user=participant)