Skip to content

feat(OGC-1054): complete guided analyzer setup and activation - #4125

Open
pmanko wants to merge 140 commits into
codex/ogc-1054-m2-mappingfrom
codex/ogc-1054-m3-setup-qc
Open

feat(OGC-1054): complete guided analyzer setup and activation#4125
pmanko wants to merge 140 commits into
codex/ogc-1054-m2-mappingfrom
codex/ogc-1054-m3-setup-qc

Conversation

@pmanko

@pmanko pmanko commented Aug 24, 2026

Copy link
Copy Markdown
Member

Scope

M3 checkpoint for guided analyzer setup, profile-pinned Bridge connectivity, exact verification and activation, linked operational QC, and audited analyzer lifecycle.

This PR is intentionally stacked on OpenELIS #4118. Its required runtime companions are Analyzer Bridge #48 at dd0e21cf43bce7c9e924ca6031cf31e82b38ad8e and analyzer-mock #40 at 504ffec81a5b93f6be91231051e8fe0720f61eb1; both companion PRs are non-draft, mergeable, and green.

Delivered slices

  • Inline Instrument, Verify, and Connect workflow with URL-backed state, reload, breadcrumbs, and exact return paths
  • Generic rendering of Bridge-owned connection descriptors; no protocol-specific OpenELIS connection form or duplicated profile defaults
  • Durable profile-pinned Bridge connections and structured, non-mutating connection probes
  • Exact mapping/recognition verification and immutable activation candidates
  • Visible activation blockers plus audited activate, deactivate, and reactivate lifecycle
  • Correct edit state for active analyzers: connection changes save without offering or repeating activation
  • Analyzer-scoped link to separate operational QC; QC never gates verification or activation
  • Lab-facing dashboard presentation aligned with the current functional/visual mock: Total, Active, In Setup, and Inactive summaries plus Name, Connection, Lab Units, Analyzer type, Status, and Actions
  • Removal of the superseded OE registration/full-state connection runtime, compatibility request fields, fixed connection storage, duplicate connection UI, and obsolete connection tests
  • Immutable shared-mapping history that permits a later revision to restore previously valid content

The earlier review comment on BridgeRegistrationService no longer applies: that OE registration builder was removed. SERIAL, HTTP, TCP, MLLP, and FILE settings are rendered and persisted generically from the Bridge-owned profile/connection contract.

Acceptance status

Roadmap checkpoint M3 is review-ready [x]. The implementation, substantive GitHub build, local quality gates, exact remote deployment, UI-only story, screenshots, and trace review are complete. The one-step GitHub backend checkpoint summary is waiting in a repository-wide hosted-runner queue; it performs no additional build or test work. M4 result traffic and held-result workflows remain outside this PR.

The still-present raw analyzer readers, plugin matching, local Analyzer Type registry, per-analyzer plugin configuration, PENDING_REGISTRATION path, and direct-to-OE mock modes are M4 removal targets after normalized Bridge traffic reaches parity. M3 does not extend those paths or add compatibility guards.

Exact remote evidence

  • OpenELIS: 3a134da00a9e7f6a2151e7ee6508fd89c00505d5
  • Analyzer Bridge: dd0e21cf43bce7c9e924ca6031cf31e82b38ad8e
  • Analyzer mock: 504ffec81a5b93f6be91231051e8fe0720f61eb1
  • Functional/visual baseline only, openelis-work@main: 201c068ed73aa22a61c3df37abc23ede942f62ed
  • Review tooling: 2ead2bbc7c1327f86c143c5e6bd03992c1971706
  • Deployment: 20260825T232826Z-3a134da00a9e, ready with health and smoke checks passed
  • Grist checklist: schema 2, 17 AN-MVP-* steps, revision 52d1e39d54994ea8473698d1922062f2b7f1e9e5164082798ef9029a16dff3d9
  • Remote UI-only M3 story: 2 passed against https://analyzers.openelis-global.org
  • Trace review: 67 debug and 5 ordinary console messages; no warnings, errors, page errors, or sensitive console values
  • Network review: 215 completed requests, 214 HTTP 200 and 1 HTTP 201; no failed or unfinished requests
  • Inspected desktop/mobile setup, In Setup dashboard, active dashboard, verification, connection evidence, and linked operational-QC screenshots
  • Shared-host AMR remained at b1c692ba930decc371a67cd7c534c663a2932471

The deployed Review widget overlaps table content on the narrow mobile screenshot. That is a review-tooling presentation defect, not an OpenELIS application defect, and remains a G0 evidence risk until corrected in the owning repository.

Automated quality gates

  • TDD inversion recorded for the dashboard setup count/columns and active-analyzer completion actions
  • Complete analyzer component suite: 10 files, 84 tests passed
  • Focused Prettier and ESLint checks passed; repository Playwright lint passed
  • Playwright bucket and harness dependency guards passed
  • Bridge Beta server bugfixes #48 and analyzer-mock java error fix to begin beta testing #40 CI passed at the exact deployed revisions
  • digi-uw/code-qa alignment, meaningful-coverage, simplicity/legacy, companion, and interim-evidence reviews completed for M3

Remaining gates

  • Completion of the queued one-step GitHub backend checkpoint summary
  • Review and strict-order merges for predecessor and M3 PRs
  • M4 normalized traffic, held-result handling, and comprehensive removal of superseded raw/plugin pathways
  • G0 named-human review of all 17 Grist steps and final MP4/screenshots/trace against one unchanged accepted deployment

The current screenshots and trace are checkpoint evidence. The final MP4 is deliberately deferred to G0 so it records the complete unchanged MVP rather than a partial checkpoint.

pmanko added 30 commits August 22, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant