Skip to content

Release/0.2.1#13

Open
jpbida wants to merge 18 commits into
DIGI-VUB:masterfrom
jpbida:release/0.2.1
Open

Release/0.2.1#13
jpbida wants to merge 18 commits into
DIGI-VUB:masterfrom
jpbida:release/0.2.1

Conversation

@jpbida

@jpbida jpbida commented Jul 28, 2022

Copy link
Copy Markdown

Features

  • Allows text input for annotation to be dynamically added.
  • annotations to be loaded
  • Tags only or Tags & Relations as an option instead of separate function
  • Moving Annotation Mode Button to RShiny input
  • Added testing for new features

Testing

  • Added selenium test for updating the text being annotated

Notes
Selenium tests sometimes fail if while the tests are running:

  • the mouse is moved over the window,
  • the window is resized
  • the server is too slow running the shiny app

@jwijffels

jwijffels commented Jul 29, 2022

Copy link
Copy Markdown
Member

Thanks again for the work on this.
Before I can work on merging this some things need to be fixed

  • r cmd check needs to pass (I've enabled CI, so you can see where R CMD check gives errors)
  • all elements / examples which were there should still work (e.g. running the first example of recogito in the README and at ?recogito already gives different results as the current package version
  • put the different elements in different pull requests
    • factor out the changes regarding unit testing (If at all these will work on all the different CRAN platforms)
    • adding changes in the javascript / R options
  • I think the following needs to be kept in mind in order not to let all function arguments explode
    • in tags we can just put a vector of tags in case of mode annotation and it can be a list of tags (for the relations and the entities) as in tags = c("location", "person") or tags = list(entity = c("location", "person"), relation = c("lives-in", "objectof"))
    • we can use 1 argument options instead of having the function arguments mode, refresh, annotationMode, document the options and handle these in the recogito function itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants