Check post-process returned value for job success#34
Merged
aldbr merged 7 commits intoDIRACGrid:mainfrom Oct 13, 2025
Merged
Conversation
Pass the parameters defined in the configuration of transformations to jobs if they are not for an input query
ddff37f to
dd3e8ff
Compare
aldbr
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix #33 and the failed tests.
The lhcb plugin had some incorrect function calls, fixing it only leaves the gaussian-fit test failing.
It seems the test for the gaussian-fit data generation was using the wrong cwl task but there was still an error after changing that.
The job's outputs were using default filenames instead of the ones defined in the configuration. I tried to fix that but I'm not 100% sure it's working as intended in all scenarios, even though the tests are now all passing.