Skip to content

Check post-process returned value for job success#34

Merged
aldbr merged 7 commits intoDIRACGrid:mainfrom
Loxeris:fix-use-postprocess-value
Oct 13, 2025
Merged

Check post-process returned value for job success#34
aldbr merged 7 commits intoDIRACGrid:mainfrom
Loxeris:fix-use-postprocess-value

Conversation

@Loxeris
Copy link
Copy Markdown
Member

@Loxeris Loxeris commented Sep 25, 2025

Aims to fix #33 and the failed tests.

The lhcb plugin had some incorrect function calls, fixing it only leaves the gaussian-fit test failing.
It seems the test for the gaussian-fit data generation was using the wrong cwl task but there was still an error after changing that.
The job's outputs were using default filenames instead of the ones defined in the configuration. I tried to fix that but I'm not 100% sure it's working as intended in all scenarios, even though the tests are now all passing.

Copy link
Copy Markdown
Contributor

@aldbr aldbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks @Loxeris 🙂

@Loxeris Loxeris force-pushed the fix-use-postprocess-value branch from ddff37f to dd3e8ff Compare October 7, 2025 09:10
@aldbr aldbr merged commit 04f318b into DIRACGrid:main Oct 13, 2025
1 check passed
@Loxeris Loxeris deleted the fix-use-postprocess-value branch October 17, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post-process return value is ignored when running a job

2 participants