Conversation
aldbr
left a comment
There was a problem hiding this comment.
Great! Thank you @AcquaDiGiorgio 🙂
I just have a few comments:
- We are streamlining the tests in parallel and the mandelbrot workflow will likely go away. Do you think you could get the same results using the
cryptoworkflow? I think it contains 4 independent steps. - Do you think we need to have a "sequential" version of the tested workflow? Naively, I think it is not necessary because it's already tested everywhere else: if dependent steps would run in parallel, other tests couldn't work.
- I think I would test the
cryptoworkflow withtaskset -c 0and thentaskset -c 0-1for instance to demonstrate the difference in duration.
Do you have any opinion? Please let me know if you think I 'm wrong
|
Due to the nature of the crypto algortithms, it might be difficult to differentiate between a parallel and a sequential execution, in both cases they get executed extremely quick. If I'm using a forced sequential workflow to be able to compare it with a parallel one that executes in one core. |
Remove unnecesary test and cwl
Remove unnecesary test and cwl
Add parallel execution at job submission by default
Tests check the following:
See #43