feat: add --chart-path option to run_demo.sh #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for installing custom Helm charts (e.g., umbrella charts for
extensions) instead of the default diracx chart.
Changes:
- Add --chart-path command-line option to specify a custom chart directory
- Default to ${script_dir}/diracx for backward compatibility
- Update usage documentation with the new option
This enables community extensions (like gubbins, lhcbdiracx) to use their
own umbrella charts that depend on the base diracx chart while leveraging
the run_demo.sh infrastructure.
Note: helm dependency build should be run on the custom chart before calling
this script (typically done in CI configuration).
chrisburr
force-pushed
the
feat/add-chart-path-option
branch
from
dd293b2 to
31c1ce3
Compare
chaen
approved these changes
Oct 27, 2025
chrisburr
added a commit
to chrisburr/diracx
that referenced
this pull request
Oct 27, 2025
Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
chrisburr
added a commit
to chrisburr/diracx
that referenced
this pull request
Oct 27, 2025
Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
chrisburr
added a commit
to chrisburr/diracx
that referenced
this pull request
Oct 27, 2025
Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
chrisburr
added a commit
to chrisburr/diracx
that referenced
this pull request
Oct 28, 2025
Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
chrisburr
added a commit
to chrisburr/diracx
that referenced
this pull request
Oct 28, 2025
Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
chrisburr
added a commit
to chrisburr/diracx
that referenced
this pull request
Oct 28, 2025
Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
chaen
pushed a commit
to DIRACGrid/diracx
that referenced
this pull request
Oct 28, 2025
* feat: add gubbins-charts Helm chart for gubbins extension Add umbrella Helm chart for the gubbins DiracX extension following the lhcbdiracx-charts pattern. This chart extends the base diracx chart with gubbins-specific configuration including: - Gubbins container image registry configuration - LollygagDB database setup - Developer mode enabled for testing - Example hostname configuration The chart serves as a tutorial and test example for community extensions. * feat: adapt gubbins CI to use gubbins-charts Update the gubbins pytest-integration CI to use the gubbins-charts umbrella chart instead of directly using the diracx chart with value overrides. Changes: - Copy gubbins-charts to /tmp/ during CI setup - Run helm dependency build on gubbins-charts before starting demo - Add --chart-path argument to run_demo.sh pointing to gubbins-charts - Simplify gubbins_values.yaml to only contain CI-specific overrides - Move base gubbins configuration to gubbins-charts/values.yaml This approach provides better separation of concerns: - Base configuration lives in gubbins-charts (part of the extension) - CI-specific overrides remain in gubbins_values.yaml - Pattern is reusable for other community extensions Related: DIRACGrid/diracx-charts#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for installing custom Helm charts (e.g., umbrella charts for extensions) instead of the default diracx chart.
This enables community extensions (like gubbins, lhcbdiracx) to use their own umbrella charts that depend on the base diracx chart while leveraging the run_demo.sh infrastructure.
Changes
--chart-pathcommand-line option to specify a custom chart directory${script_dir}/diracxfor backward compatibilityNote:
helm dependency buildshould be run on the custom chart before calling this script (typically done in CI configuration).Usage Example
Testing
This will be tested in conjunction with DIRACGrid/diracx#691 which creates the gubbins-charts umbrella chart and updates the CI to use it.
Related PRs
--chart-path