fix: Running the demo for extension charts #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
run_demo.shscript to improve tool management and clarify the use of custom Helm charts. The most significant changes are the switch to usingarkadefor downloading required binaries, and the renaming and enhanced handling of the custom chart path option. These changes streamline the setup process and make the script more robust and user-friendly.Tool management improvements:
kind,kubectl, andhelmwitharkade, which now handles downloading these tools (as well asyq) into the.demodirectory, reducing system dependencies and simplifying the script logic. (run_demo.sh)Helm chart customization enhancements:
--chart-pathoption to--extension-chart-pathfor improved clarity, and updated all related help messages and error handling to match the new name. (run_demo.sh) [1] [2]diracxtop section usingyq, ensuring compatibility with umbrella charts. (run_demo.sh)