Skip to content

feat: add a cronjob to cleanup the authdb tables#241

Open
HeloiseJoffe wants to merge 4 commits intoDIRACGrid:masterfrom
HeloiseJoffe:feat/authdb-cleanup-cronjob
Open

feat: add a cronjob to cleanup the authdb tables#241
HeloiseJoffe wants to merge 4 commits intoDIRACGrid:masterfrom
HeloiseJoffe:feat/authdb-cleanup-cronjob

Conversation

@HeloiseJoffe
Copy link

Related to DIRACGrid/diracx#815
Related to #222

Changes:

  • Add a Kubernetes CronJob
  • Add Documentations

@natthan-pigoux
Copy link
Contributor

You could also add a comment like here to explain that we can set: DIRACX_SERVICE_AUTH_REVOKED_REFRESH_TOKEN_RETENTION_DAYS and DIRACX_SERVICE_AUTH_COMPLETED_FLOW_RETENTION_MINUTES to tune the clean up by the cronJob.

@chrisburr chrisburr marked this pull request as draft March 5, 2026 07:47
@natthan-pigoux
Copy link
Contributor

natthan-pigoux commented Mar 5, 2026

I think there was a confusion here. I just saw that you added the cron job in k3s/manifests, but I think it should go in diracx > templates > diracx > clean-auth-db

@HeloiseJoffe
Copy link
Author

Yes I know I'm actually changing it

@HeloiseJoffe HeloiseJoffe force-pushed the feat/authdb-cleanup-cronjob branch 2 times, most recently from 4912881 to c2c6537 Compare March 10, 2026 09:29
@HeloiseJoffe
Copy link
Author

The pipeline is failing because the architecture diagram has changed with the addition of the new CronJob.
Here is the newly generated diagram:
architecture_diagram
Could someone with CERN access upload it to replace the current one?

@HeloiseJoffe HeloiseJoffe marked this pull request as ready for review March 10, 2026 10:13
@HeloiseJoffe HeloiseJoffe requested a review from aldbr March 10, 2026 10:13
natthan-pigoux
natthan-pigoux previously approved these changes Mar 11, 2026
Copy link
Contributor

@natthan-pigoux natthan-pigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HeloiseJoffe , looks fine for me now.

Copy link
Contributor

@aldbr aldbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HeloiseJoffe, I just have very minor comments 🙂
@chrisburr could you explain me how we are supposed to upload the new diagram please?

@DIRACGridBot DIRACGridBot marked this pull request as draft March 11, 2026 17:46
@HeloiseJoffe HeloiseJoffe force-pushed the feat/authdb-cleanup-cronjob branch from 55a52be to 4b835fb Compare March 18, 2026 13:54
@HeloiseJoffe HeloiseJoffe marked this pull request as ready for review March 18, 2026 14:08
@HeloiseJoffe HeloiseJoffe requested a review from aldbr March 18, 2026 14:08
aldbr
aldbr previously approved these changes Mar 18, 2026
@aldbr aldbr linked an issue Mar 18, 2026 that may be closed by this pull request
@DIRACGridBot DIRACGridBot marked this pull request as draft March 18, 2026 15:20
@aldbr
Copy link
Contributor

aldbr commented Mar 18, 2026

The diracx related PR has been merged. I think we now need to wait for a new diracx release within the charts to merge this one I guess, because the cleanup function does not exist yet.

natthan-pigoux
natthan-pigoux previously approved these changes Mar 19, 2026
@aldbr aldbr marked this pull request as ready for review March 19, 2026 10:06
@aldbr aldbr dismissed stale reviews from natthan-pigoux and themself via 680b798 March 25, 2026 08:50
@aldbr aldbr force-pushed the feat/authdb-cleanup-cronjob branch from 4b835fb to 680b798 Compare March 25, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup of the AuthDB tables

4 participants