feat: form config #306
Open
feat: form config #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementNumericite
force-pushed
the
feat/form-config
branch
from
a0f6174 to
76e9eb7
Compare
Comment on lines
76
to
88
| const [nbrModified, setNbrModified] = useState( | ||
| configHelper.displays.filter( | ||
| d => d.kind === 'blockOption' && block.id === d.parent_id && d.hidden | ||
| ).length | ||
| ); | ||
|
|
||
| useEffect(() => { | ||
| setNbrModified( | ||
| configHelper.displays.filter( | ||
| d => d.kind === 'blockOption' && step.form_template_blocks.map(b => b.id).includes(d.parent_id) && d.hidden | ||
| ).length | ||
| ) | ||
| }, [configHelper]) |
There was a problem hiding this comment.
pas mieux de faire une const pour éviter tout ce code ?
Comment on lines
50
to
67
| const [isModified, setIsModified] = useState( | ||
| configHelper.displays.some( | ||
| d => d.kind === 'blockOption' && step.form_template_blocks.map(b => b.id).includes(d.parent_id) && d.hidden | ||
| ) || configHelper.labels.some(d => { | ||
| if (d.kind !== 'block') return false; | ||
|
|
||
| const isInCorrectBlock = step.form_template_blocks.map(b => b.id).includes(d.parent_id); | ||
|
|
||
| const paragraphContent = step.form_template_blocks.find(b => b.type_bloc === 'paragraph')?.content; | ||
| if (!paragraphContent) return false; | ||
|
|
||
| const replacedContent = paragraphContent.replace('{{title}}', form.product.title); | ||
|
|
||
| return isInCorrectBlock && | ||
| normalizeHtml(d.label) !== normalizeHtml(replacedContent); | ||
| }) | ||
| ); | ||
|
|
There was a problem hiding this comment.
faut qu'on pense a une implem différente
à mon avis il faudrait répéter l'id de la step dans les configs, ça éviterai d'avoir a faire tout ça à chaque fois
…to render a table as rows of scales to adapt design, removed option 'no answer' from seeding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.