Skip to content

Update Voxglitch.#787

Open
rl2939 wants to merge 8 commits into
DISTRHO:mainfrom
rl2939:update-voxglitch
Open

Update Voxglitch.#787
rl2939 wants to merge 8 commits into
DISTRHO:mainfrom
rl2939:update-voxglitch

Conversation

@rl2939

@rl2939 rl2939 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@rl2939

rl2939 commented Nov 16, 2025

Copy link
Copy Markdown
Contributor Author

I am unable to update this pull request any further because I keep getting compile errors.
At this point, I can only merge the main branch in without having checks fail.

Does the Cardinal project want to accept this pull request as-is, or should I close this pull request?

@dromer

dromer commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

I don't see any compile errors?

@rl2939

rl2939 commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

I don't see any compile errors?

That is because I am still building off of an older version of Voxglitch. However, when I try to build off of the latest version/ commit, I get this error:

Compiling plugins.cpp
Compiling voxglitch/src/modules/ArpSeq.cpp
voxglitch/src/modules/ArpSeq.cpp:16:10: fatal error: vgLib-2.0/constants.h: No such file or directory
   16 | #include "vgLib-2.0/constants.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:2836: ../build/plugins/voxglitch/src/modules/ArpSeq.cpp.o] Error 1

That is why I am asking the question: does the Cardinal project want to accept this pull request as-is, or should I close this pull request?

(If you think you can help with fixing the compile error, I can also push the commit with the compile error to this pull request.)

@dromer

dromer commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

Probably needs an include path added to the Makefile? I see it right there in the src/ dir.

Maybe I can investigate this later.

@dromer

dromer commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

Hmm, trying this out and there are definitely some issues with includes in the latest voxglitch.
I don't know what is the best way to move forward.

Or we park the efforts at your current work and then look at the other changes later.

@rl2939

rl2939 commented Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

Or we park the efforts at your current work and then look at the other changes later.

I think parking the efforts here is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants