Skip to content

Sapphire v2.5.9 - new module Echo#832

Merged
falkTX merged 3 commits into
DISTRHO:mainfrom
cosinekitty:sapphire_v2.5.9
May 31, 2025
Merged

Sapphire v2.5.9 - new module Echo#832
falkTX merged 3 commits into
DISTRHO:mainfrom
cosinekitty:sapphire_v2.5.9

Conversation

@cosinekitty

Copy link
Copy Markdown
Contributor
  • Added a new multitap delay module: Echo.
  • Added neon mode menu options to make the Sapphire panel glow. This effect is most visible when the room brightness is dim.
  • Chaops did not reset the FREEZE button on initialize. This has been fixed.
  • Fixed minor polyphony bug in Env: the number of channels in the GAIN control's CV input did not affect the number of output channels. This has been fixed.
  • Fixed typos in help text for Gravy and Sauce.

Added a new multitap delay module: [Echo](https://github.com/cosinekitty/sapphire/blob/main/doc/Echo.md).
Added "neon mode" menu options to make the Sapphire panel glow. This effect is most visible when the room brightness is dim.
Chaops did not reset the FREEZE button on initialize. This has been fixed.
Fixed minor polyphony bug in Env: the number of channels in the GAIN control's CV input did not affect the number of output channels. This has been fixed.
Fixed typos in help text for Gravy and Sauce.
@cosinekitty

Copy link
Copy Markdown
Contributor Author

My PR clearly has some memory issues that need to be fixed. I will try again later once I have fixed this.

@dromer

dromer commented May 28, 2025

Copy link
Copy Markdown
Collaborator

Hmm, little hiccup on some of the steps. Will give them a restart once the rest finishes.

@cosinekitty

Copy link
Copy Markdown
Contributor Author

Hmm, little hiccup on some of the steps. Will give them a restart once the rest finishes.

Thank you! Yeah, this time it didn't look like it was my fault, LOL.

@cosinekitty

Copy link
Copy Markdown
Contributor Author

The win32 problem is mine, and I created an issue for it on the Sapphire repo.

The linux/aarch64 failure looks like it might go away if we ignore it long enough.

Tomorrow I will fix the win32 issue and try again.

@falkTX

falkTX commented May 29, 2025

Copy link
Copy Markdown
Contributor

Try adding -DSKIP_MINGW_FORMAT to your plugin build flags in plugins/Makefile

There was a compatibility problem between MINGW and
my own member function named `format`. I don't need MINGW
so I disabled it in the Cardinal Makefile.

This solution was suggested by @falkTX.
It is nice because I don't have to change any Sapphire code!
@cosinekitty

cosinekitty commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

I believe I have fixed problems related to Sapphire. The remaining problem appears to be something to do with package management. Sounds like this is something you guys will need to fix because it will affect all your builds. But please let me know if I can help in any way. I will leave this PR parked here for now.

@cosinekitty

Copy link
Copy Markdown
Contributor Author

Oh nice, the build is working again!

@falkTX falkTX merged commit 87d6e4e into DISTRHO:main May 31, 2025
93 of 101 checks passed
@falkTX

falkTX commented May 31, 2025

Copy link
Copy Markdown
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants