Sapphire v2.5.9 - new module Echo#832
Conversation
cosinekitty
commented
May 27, 2025
- Added a new multitap delay module: Echo.
- Added neon mode menu options to make the Sapphire panel glow. This effect is most visible when the room brightness is dim.
- Chaops did not reset the FREEZE button on initialize. This has been fixed.
- Fixed minor polyphony bug in Env: the number of channels in the GAIN control's CV input did not affect the number of output channels. This has been fixed.
- Fixed typos in help text for Gravy and Sauce.
Added a new multitap delay module: [Echo](https://github.com/cosinekitty/sapphire/blob/main/doc/Echo.md). Added "neon mode" menu options to make the Sapphire panel glow. This effect is most visible when the room brightness is dim. Chaops did not reset the FREEZE button on initialize. This has been fixed. Fixed minor polyphony bug in Env: the number of channels in the GAIN control's CV input did not affect the number of output channels. This has been fixed. Fixed typos in help text for Gravy and Sauce.
|
My PR clearly has some memory issues that need to be fixed. I will try again later once I have fixed this. |
|
Hmm, little hiccup on some of the steps. Will give them a restart once the rest finishes. |
Thank you! Yeah, this time it didn't look like it was my fault, LOL. |
|
The win32 problem is mine, and I created an issue for it on the Sapphire repo. The linux/aarch64 failure looks like it might go away if we ignore it long enough. Tomorrow I will fix the win32 issue and try again. |
|
Try adding |
There was a compatibility problem between MINGW and my own member function named `format`. I don't need MINGW so I disabled it in the Cardinal Makefile. This solution was suggested by @falkTX. It is nice because I don't have to change any Sapphire code!
|
I believe I have fixed problems related to Sapphire. The remaining problem appears to be something to do with package management. Sounds like this is something you guys will need to fix because it will affect all your builds. But please let me know if I can help in any way. I will leave this PR parked here for now. |
|
Oh nice, the build is working again! |
|
Thanks again! |