Skip to content

fix: make the atom format spec-compliant #20723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ouuan wants to merge 6 commits into
base: master
Choose a base branch
from
+7 −10
Open

fix: make the atom format spec-compliant #20723

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a60c6de
fix: remove the src attribute of atom:content
ouuan Dec 18, 2025
959b8ad
fix: move <language> to xml:lang
ouuan Dec 18, 2025
c0e8ce8
fix: remove <webMaster> in atom
ouuan Dec 18, 2025
fa57cd1
fix: use ISO format to display date in atom & always have <updated>
ouuan Dec 18, 2025
3a78fb7
fix: use ISO date for feed <updated> in atom
ouuan Dec 18, 2025
ab6f2bc
fix: add <link rel=self> for atom
ouuan Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions lib/views/atom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@ import type { FC } from 'hono/jsx';
import type { Data } from '@/types';

const RSS: FC<{ data: Data }> = ({ data }) => (
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:rsshub="http://rsshub.app/xml/schemas">
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:rsshub="http://rsshub.app/xml/schemas" xml:lang={data.language || 'en'}>
Copy link
Contributor Author

@ouuan ouuan Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should only set the attribute if it's not undefined? Perhaps also for RSS?

<title>{data.title || 'RSSHub'}</title>
<link href={data.link || 'https://docs.rsshub.app'} />
<link rel="alternate" href={data.link || 'https://docs.rsshub.app'} />
<link rel="self" href={data.atomlink} type="application/atom+xml" />
<id>{data.id || data.link}</id>
<subtitle>{data.description || data.title} - Powered by RSSHub</subtitle>
<generator>RSSHub</generator>
<webMaster>[email protected] (RSSHub)</webMaster>
<language>{data.language || 'en'}</language>
<updated>{data.lastBuildDate}</updated>
<updated>{new Date(data.lastBuildDate || new Date()).toISOString()}</updated>
<author>
<name>{data.author || 'RSSHub'}</name>
</author>
Expand All @@ -21,13 +20,11 @@ const RSS: FC<{ data: Data }> = ({ data }) => (
{data.item?.map((item) => (
<entry>
<title>{item.title}</title>
<content type="html" src={item.link}>
{item.description}
</content>
<content type="html">{item.description}</content>
<link href={item.link} />
<id>{item.guid || item.link || item.title}</id>
{item.pubDate && <published>{item.pubDate}</published>}
{item.updated && <updated>{item.updated || item.pubDate}</updated>}
{item.pubDate && <published>{new Date(item.pubDate).toISOString()}</published>}
<updated>{new Date(item.updated || item.pubDate || new Date()).toISOString()}</updated>
{item.author && (
<author>
<name>{item.author}</name>
Expand Down
Loading