Skip to content

fix(routes/mercari): use item updated time in cache key #20726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ouuan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(routes/mercari): use item updated time in cache key #20726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f22c86a
Revert "fix(routes/mercari): set cache max age to routeExpire (#20653)"
ouuan Dec 18, 2025
50f4da5
fix(routes/mercari): use item updated time in cache key
ouuan Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/routes/mercari/keyword.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { config } from '@/config';
import type { Route } from '@/types';
import cache from '@/utils/cache';

Expand Down Expand Up @@ -59,9 +58,7 @@ async function handler(ctx) {
const { sort, order, status, keyword } = ctx.req.param();
const statusArray = MercariStatus[status] ? [MercariStatus[status]] : [];
const searchItems = (await fetchSearchItems(MercariSort[sort], MercariOrder[order], statusArray, keyword)).items;
const items = await Promise.all(
searchItems.map((item) => cache.tryGet(`mercari:${item.id}`, async () => await fetchItemDetail(item.id, item.itemType).then((detail) => formatItemDetail(detail)), config.cache.routeExpire, false))
);
const items = await Promise.all(searchItems.map((item) => cache.tryGet(`mercari:${item.id}:${item.updated}`, async () => await fetchItemDetail(item.id, item.itemType).then((detail) => formatItemDetail(detail)))));

return {
title: `${keyword} の検索結果`,
Expand Down
5 changes: 1 addition & 4 deletions lib/routes/mercari/search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { config } from '@/config';
import type { Route } from '@/types';
import cache from '@/utils/cache';

Expand Down Expand Up @@ -88,9 +87,7 @@ async function handler(ctx) {
const { keyword, sort, order, status, options } = parseSearchQuery(queryString);
const searchItems = (await fetchSearchItems(sort, order, status, keyword, options)).items;

const items = await Promise.all(
searchItems.map((item) => cache.tryGet(`mercari:${item.id}`, async () => await fetchItemDetail(item.id, item.itemType).then((detail) => formatItemDetail(detail)), config.cache.routeExpire, false))
);
const items = await Promise.all(searchItems.map((item) => cache.tryGet(`mercari:${item.id}:${item.updated}`, async () => await fetchItemDetail(item.id, item.itemType).then((detail) => formatItemDetail(detail)))));

return {
title: `${keyword} の検索結果`,
Expand Down