Skip to content

feat(route): add Minhang Museum exhibition route - #23117

Open
magazian wants to merge 2 commits into
DIYgod:masterfrom
magazian:feat-minhangmuseum
Open

feat(route): add Minhang Museum exhibition route#23117
magazian wants to merge 2 commits into
DIYgod:masterfrom
magazian:feat-minhangmuseum

Conversation

@magazian

Copy link
Copy Markdown
Contributor

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/minhangmuseum/interim

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

@github-actions github-actions Bot added the route label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Auto Review

  • [Description Content / Rule 11, 22] lib/routes/minhangmuseum/interim.tsx: the description is built entirely from metadata — it repeats the pubDate (the 开展 date is exactly what is passed to pubDate) plus 闭展/原始展期/地点, and contains no actual exhibition content. Fix: fetch the exhibition introduction body from the detail page (the detail $detail object is already loaded) and render that as description; drop the 开展 line since it duplicates pubDate.

  • [Valid Item Properties / Rule 18] lib/routes/minhangmuseum/interim.tsx: the _extra: { museumName, location, startDate, endDate } fields are custom keys that RSSHub never emits, so they are dead weight in the cached payload. Fix: remove the _extra block (keep location/dates only where they are actually rendered).

@github-actions github-actions Bot added the auto: not ready to review Users can't get the RSS feed output according to automated testing results label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Successfully generated as following:

http://localhost:1200/minhangmuseum/interim - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://minhangmuseum.shmh.gov.cn/weixin/interim/list.htm&quot;: 403 Forbidden
Route: /minhangmuseum/interim
Full Route: /minhangmuseum/interim
Node Version: v24.19.0
Git Hash: 507a266d

@magazian

Copy link
Copy Markdown
Contributor Author
image the route works locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto: not ready to review Users can't get the RSS feed output according to automated testing results route

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant