Skip to content

fix(route/latepost): include cover image and abstract in description #23121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esonwong wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

fix(route/latepost): include cover image and abstract in description #23121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/routes/latepost/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,21 @@ async function handler(ctx): Promise<Data> {
const content = load(detailResponse);

item.title ??= content('div.article-header-title').text();
item.description = content('#select-main').html()!.replaceAll('<p><br></p>', '');

// The cover image lives outside of the article body (#select-main), in either the
// `.abstract` block (exclusives / long reads) or `.interview-pic` (interviews).
// Fall back to the share image embedded in the page script, which covers both layouts.
let cover = content('#abstract_img').attr('src') || content('img.interview-pic').attr('src');
if (!cover) {
cover = /var\s+imgUrl\s*=\s*'([^']+)'/.exec(detailResponse)?.[1];
}
// The site serves the cover over plain http, which readers may refuse to load.
const coverHtml = cover ? `<img src="${new URL(cover, rootUrl).href.replace(/^http:/, 'https:')}">` : '';

const abstract = content('div.abstract-pic-left').text().trim();
const abstractHtml = abstract ? `<blockquote>${abstract}</blockquote>` : '';

item.description = coverHtml + abstractHtml + content('#select-main').html()!.replaceAll('<p><br></p>', '');
item.author = content('div.article-header-author div.author-link a.label').first().text();
item.category = item.category.filter(Boolean);
item.guid = `latepost-${item.guid}`;
Expand Down