Reduce Amount of Allocations

[florianhartung]

Open Questions / TODOs

Benchmark Results

Coremark Results:

On main I get 311 and 312. On this branch I get 344 and 348.

I expect that the optimized br_table execution is responsible for this. Maybe it's in a hot loop somewhere. The coremark benchmark definitly contains ~10 br.table instructions

References

Checks

• Using Nix
  • Ran nix fmt
  • Ran nix flake check '.?submodules=1'
• Using Rust tooling
  • Ran cargo fmt
  • Ran cargo test
  • Ran cargo check
  • Ran cargo build
  • Ran cargo clippy --workspace
  • Ran cargo doc --document-private-items --workspace

[codecov]

Codecov Report

❌ Patch coverage is 87.61261% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.11%. Comparing base (423c20f) to head (a24225e).

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   88.15%   88.11%   -0.05%     
==========================================
  Files          59       59              
  Lines       14769    14895     +126     
  Branches    14769    14895     +126     
==========================================
+ Hits        13020    13125     +105     
- Misses       1045     1061      +16     
- Partials      704      709       +5     

Components	Coverage Δ
interpreter	88.11% <87.61%> (-0.05%)	⬇️
checked	∅ <ø> (∅)
linker	∅ <ø> (∅)
interop	∅ <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cemonem]

in a future pr, we can remove this stack all together and have a flag if we're supposed to have more than 1 item in the stack (that we pretend to have) since all constexpr instructions are already values by themselves

[florianhartung]

AFAIK we discussed this topic already. For now, I'd like to keep the stack because it allows us to easily implement the Extended Const Expressions proposal (which is part of Wasm 3)

[florianhartung]

However, the value stack may be untyped for constant expressions. #394 combined with #389 may therefore result in quite performant code