Skip to content

Remove Redundant Capacity Check in Stack::push_call_frame - #392

Open
florianhartung wants to merge 1 commit into
mainfrom
dev/remove-redundant-value-stack-check
Open

Remove Redundant Capacity Check in Stack::push_call_frame#392
florianhartung wants to merge 1 commit into
mainfrom
dev/remove-redundant-value-stack-check

Conversation

@florianhartung

Copy link
Copy Markdown
Collaborator

Open Questions / TODOs

Benchmark Results

References

Closes #387

Checks

  • Using Nix
    • Ran nix fmt
    • Ran nix flake check '.?submodules=1'
  • Using Rust tooling
    • Ran cargo fmt
    • Ran cargo test
    • Ran cargo check
    • Ran cargo build
    • Ran cargo clippy --workspace
    • Ran cargo doc --document-private-items --workspace

Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung florianhartung self-assigned this Jul 28, 2026
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (77495f3) to head (eddca6d).
⚠️ Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   83.71%   83.72%           
=======================================
  Files          59       59           
  Lines       10600    10597    -3     
  Branches    10600    10597    -3     
=======================================
- Hits         8874     8872    -2     
+ Misses       1031     1030    -1     
  Partials      695      695           
Components Coverage Δ
interpreter 83.72% <100.00%> (+<0.01%) ⬆️
checked ∅ <ø> (∅)
linker ∅ <ø> (∅)
interop ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@florianhartung

Copy link
Copy Markdown
Collaborator Author

Re-introduce the check but without the generic. Instead check against the capacity of the fixed capacity vec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove T Generic From Stack::push_call_frame

2 participants