Remove Redundant Capacity Check in Stack::push_call_frame - #392
Open
florianhartung wants to merge 1 commit into
Open
Remove Redundant Capacity Check in Stack::push_call_frame#392florianhartung wants to merge 1 commit into
Stack::push_call_frame#392florianhartung wants to merge 1 commit into
Conversation
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 83.71% 83.72%
=======================================
Files 59 59
Lines 10600 10597 -3
Branches 10600 10597 -3
=======================================
- Hits 8874 8872 -2
+ Misses 1031 1030 -1
Partials 695 695
🚀 New features to boost your workflow:
|
cemonem
approved these changes
Jul 29, 2026
Collaborator
Author
|
Re-introduce the check but without the generic. Instead check against the capacity of the fixed capacity vec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Questions / TODOs
Benchmark Results
References
Closes #387
Checks
nix fmtnix flake check '.?submodules=1'cargo fmtcargo testcargo checkcargo buildcargo clippy --workspacecargo doc --document-private-items --workspace