Fixed bug in simulations w.r.t. default params. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug in the simulation classes, where the default parameter is used if the given parameter is 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the simulation classes, where the default parameter is wrongly used if the parameter is set to 0.
The previous parameter assignment in the
__init__of the simulation classes is done by:self.<param> = <param> or self.default_parameters["<param>"]This leads to wrong behavior if you want to set the
<param>to 0, as in these cases, the default parameter is used.In this pull-request the parameter is changed to the following to get the correct behavior:
self.<param> = <param> if <param> is not None else self.default_parameters["<param>"]