Add check_vecenv function for VecEnv validation similar to env_checker#2178
Add check_vecenv function for VecEnv validation similar to env_checker#2178
Conversation
Co-authored-by: araffin <1973948+araffin@users.noreply.github.com>
VecEnv checker for SB3 VecEnv (see issue #1251), don't forget to add tests and update the changelog (details are in the contributing guide).|
@copilot the env checker file is too long, put the vec env checker code in another file, same for the tests. |
Co-authored-by: araffin <1973948+araffin@users.noreply.github.com>
Done! Refactored the VecEnv checker implementation to address all your feedback: Code Organization:
Documentation:
All functionality preserved, all tests pass (6 new VecEnv tests + 25 original env_checker tests). The env_checker.py file is now back to its original length without the VecEnv code. Commit: 005ab7f |
|
@copilot check that the proposes changes do not raise any new issues from the linter/type checker (use Whenever possible, give more information about expected type to the user, for instance Do not use |
Co-authored-by: araffin <1973948+araffin@users.noreply.github.com>
Done! Fixed all linting, type checking, and documentation build issues: Linting & Type Checking: Improvements Made:
All tests still pass (6 VecEnv tests + 25 original env_checker tests). The implementation now follows all project standards. Commit: ff2c000 |
closes #1251
Summary
Fixed all linting, type checking, and documentation build issues while improving the VecEnv checker implementation.
✅ Completed Fixes
Code Quality:
_check_vecenv_unsupported_spacesby reusing existing functionError Messages:
Code Reuse:
_check_box_obsfor observation space validation_check_unsupported_spacesfor space compatibility warningsException Handling:
try/except Exceptionblocks as requestedLinting Results:
The VecEnv checker now provides better error messages, reuses existing code properly, and follows all project coding standards.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.