Add setter for tixiDocument filepath #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joergbrech
requested changes
Dec 1, 2025
Contributor
joergbrech
left a comment
joergbrech
left a comment
There was a problem hiding this comment.
Looks good! I just have some docstring comments.
Also, could you append the Changelog?
joergbrech
reviewed
Dec 4, 2025
joergbrech
reviewed
Dec 4, 2025
joergbrech
approved these changes
Dec 8, 2025
joergbrech
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to set an intended filepath to a newly created document. As described in #257 this fixes an issue in TiGL that occurs when configurations need to be reloaded from string and the process requires information about the documents filepath.
A test was added to check the new function. It was tested with tigl, and fixes TiGL issue 1219. See also TiGL draft- PR 1266