Skip to content

cptbox: compare projected with real instead of normalized #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Riolku wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cptbox: compare projected with real instead of normalized #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dmoj/cptbox/isolate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ def _access_check(self, debugger: Debugger, file: str, fs_jail: FilesystemPolicy
real = os.path.realpath(file)

try:
same = normalized == real or os.path.samefile(projected, real)
same = projected == real or os.path.samefile(projected, real)
except OSError:
raise DeniedSyscall(ACCESS_ENOENT, f'Cannot stat, file: {file}, projected: {projected}, real: {real}')

Expand All @@ -366,7 +366,7 @@ def _access_check(self, debugger: Debugger, file: str, fs_jail: FilesystemPolicy
if not fs_jail.check(normalized):
raise DeniedSyscall(ACCESS_EACCES, f'Denying {file}, normalized to {normalized}')

if normalized != real:
if projected != real:
proc_dir = f'/proc/{debugger.tid}'
if real.startswith(proc_dir):
real = os.path.join('/proc/self', os.path.relpath(real, proc_dir))
Expand Down