Skip to content

Feature: Proper type prettification #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: development
Choose a base branch
from
Open

Conversation

DNKpp
Copy link
Owner

@DNKpp DNKpp commented Apr 14, 2025

No description provided.

@DNKpp DNKpp added the enhancement New feature or request label Apr 14, 2025
Copy link

codacy-production bot commented Apr 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.94% (target: -1.00%) 95.32%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (06d1ec3) 1714 1704 99.42%
Head commit (137a298) 2228 (+514) 2194 (+490) 98.47% (-0.94%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#110) 513 489 95.32%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 54 lines in your changes missing coverage. Please review.

Project coverage is 94.52%. Comparing base (06d1ec3) to head (137a298).

Files with missing lines Patch % Lines
include/mimic++/printing/type/NameParser.hpp 90.17% 12 Missing and 28 partials ⚠️
include/mimic++/printing/type/NameLexer.hpp 85.33% 11 Missing ⚠️
include/mimic++/utilities/Algorithm.hpp 90.32% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #110      +/-   ##
===============================================
- Coverage        96.32%   94.52%   -1.81%     
===============================================
  Files               47       49       +2     
  Lines             1714     2228     +514     
  Branches           643      812     +169     
===============================================
+ Hits              1651     2106     +455     
- Misses              13       41      +28     
- Partials            50       81      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Apr 15, 2025

Pull Request Test Coverage Report for Build 14535884439

Details

  • 489 of 513 (95.32%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 98.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/mimic++/utilities/Algorithm.hpp 30 31 96.77%
include/mimic++/printing/type/NameLexer.hpp 64 75 85.33%
include/mimic++/printing/type/NameParser.hpp 395 407 97.05%
Totals Coverage Status
Change from base Build 14413863449: -0.9%
Covered Lines: 2194
Relevant Lines: 2228

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants