Skip to content

Feature: Enhance type printing #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Jan 24, 2025
Merged

Feature: Enhance type printing #97

merged 52 commits into from
Jan 24, 2025

Conversation

DNKpp
Copy link
Owner

@DNKpp DNKpp commented Jan 21, 2025

No description provided.

@DNKpp DNKpp added the enhancement New feature or request label Jan 21, 2025
Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.13% (target: -1.00%) 99.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6d50899) 1337 1335 99.85%
Head commit (92d1859) 1442 (+105) 1438 (+103) 99.72% (-0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#97) 233 232 99.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 94.84979% with 12 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (6d50899) to head (92d1859).
Report is 53 commits behind head on development.

Files with missing lines Patch % Lines
include/mimic++/printing/TypePrinter.hpp 93.10% 0 Missing and 8 partials ⚠️
include/mimic++/printing/StatePrinter.hpp 95.95% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development      #97      +/-   ##
===============================================
- Coverage        96.85%   96.32%   -0.54%     
===============================================
  Files               28       29       +1     
  Lines             1337     1442     +105     
  Branches           432      501      +69     
===============================================
+ Hits              1295     1389      +94     
- Misses               7       10       +3     
- Partials            35       43       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 12954174509

Details

  • 231 of 232 (99.57%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 99.723%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/mimic++/printing/StatePrinter.hpp 98 99 98.99%
Files with Coverage Reduction New Missed Lines %
include/mimic++/String.hpp 1 93.75%
include/mimic++/Sequence.hpp 1 98.67%
Totals Coverage Status
Change from base Build 12883873691: -0.1%
Covered Lines: 1438
Relevant Lines: 1442

💛 - Coveralls

DNKpp added 26 commits January 23, 2025 19:49
@DNKpp DNKpp merged commit 92d1859 into development Jan 24, 2025
33 of 36 checks passed
@DNKpp DNKpp deleted the dev/TypePrinter branch January 24, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants