[FEAT/seminar6] 필수과제 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jokwanhee
reviewed
Dec 5, 2023
Member
Jokwanhee
left a comment
Jokwanhee
left a comment
There was a problem hiding this comment.
로그인 처리를 데이터 바인딩으로 진행하니 코드가 깔끔합니다! 저도 한 번 적용해봐야겠어요~ 고생하셨습니다 !!
| private val _signUpEnabled = MutableLiveData<Boolean>() | ||
| val signUpEnabled: LiveData<Boolean> = _signUpEnabled | ||
|
|
||
| val checkBtnEnabled = MediatorLiveData<Boolean>().apply { |
Member
There was a problem hiding this comment.
MediatorLiveData 는 처음 보네요.. 여러 개의 LiveData를 결합해서 관리한다... 좋은 정보 얻고갑니다
yeonjeen
reviewed
Dec 6, 2023
| checkUserNameValid() | ||
| checkPassWordValid() | ||
| } | ||
|
|
There was a problem hiding this comment.
이렇게 함수를 또 묶어서 사용하는 건 생각도 못하고 따로 따로 함수만 만들어놨는데..! 저도 한 번 이렇게 해봐야겠어용!!
kez-lab
approved these changes
Dec 10, 2023
Comment on lines
+37
to
+42
| val currentFocus = currentFocus | ||
| if (currentFocus is EditText) { | ||
| currentFocus.clearFocus() | ||
| val inputMethodManager = getSystemService(INPUT_METHOD_SERVICE) as InputMethodManager | ||
| inputMethodManager.hideSoftInputFromWindow(currentFocus.getWindowToken(), 0) | ||
| } |
| private val _signUpEnabled = MutableLiveData<Boolean>() | ||
| val signUpEnabled: LiveData<Boolean> = _signUpEnabled | ||
|
|
||
| val checkBtnEnabled = MediatorLiveData<Boolean>().apply { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Work Description
📸 ScreenShot
seminar6.mp4
🍀 Issues
✔️ PR point