PVL Core #5717

amystamile-usgs · 2025-01-29T16:55:25Z

Description

Related Issue

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2025-01-29T16:56:16Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-01-31T15:18:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-01-31T15:31:03Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-02-03T20:04:45Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-02-04T15:17:08Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs · 2025-02-04T15:17:20Z

@Kelvinrr This should be ready for a review. I guess there is still the question of whether or not these changes are API breaking.

github-actions · 2025-02-05T17:19:27Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-02-06T15:39:42Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-10T15:23:44Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs · 2025-04-10T17:50:54Z

Rebased and no new tests failing outside of the dev test failures.

github-actions · 2025-09-03T21:29:15Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-04T18:50:48Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

* Fixed pvl core test config * Changed cmake_source to project_source for submodule

* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build

…ase-folding file system

github-actions · 2025-09-05T18:07:55Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

…the build and install

github-actions · 2025-09-09T17:44:11Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-09T21:11:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs requested a review from Kelvinrr February 4, 2025 15:17

amystamile-usgs force-pushed the new_pvl_core branch from 3e0c293 to aa1c64e Compare April 10, 2025 15:22

acpaquette force-pushed the new_pvl_core branch from aa1c64e to aefbe64 Compare September 3, 2025 21:28

AustinSanders and others added 15 commits September 5, 2025 11:06

Added history comment.

afa13b5

Initial move to core

e4bbcad

Removed Pvl cmakelists

07e63f6

Removed more cmakelists.txt

01559c7

Add subdirectory

4d28299

Fully modularized core

bf4da22

Fully modularized core

46a5445

replaced PvlEditDialog that was accidentally removed in prev commit

37e95a5

Initial constants unit gtest

3101e26

Fixed pvl core test config (#4349)

a799993

* Fixed pvl core test config * Changed cmake_source to project_source for submodule

Fixed pvl core test config

531ada4

Changed cmake_source to project_source for submodule

25d8dc6

First working swig wrappers

3d371fc

Rebased off of pvl_core

c4e4c8d

Moved old ISIS unitTests into core (#4351)

6884740

* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build

acpaquette and others added 23 commits September 5, 2025 11:06

Updated IException test truth data

5bf9809

Moved Endian into core

5f0cc1e

Remove additional 'm' extension for python 3.10

574bc06

Set version to 0.0.1 and clamped qt bellow 5.15

3a83e5f

Initial changes for isis pvl python interface

f5bf8f1

Removed prints causing test failures

733f2f5

Update version to 1.0.0

80495d3

Added cxx-compiler as a build dependency

1b4b0d4

Added mesalib as a build and run dependency

1bea711

Changed all Endian.h to IEndian.h to prevent include shadowing in a c…

6071d4d

…ase-folding file system

Fixed python find for python 3.9

c9bfb22

Fix python find for 3.11

f8f3dbb

Changed mention of isisio to isiscore

c06e796

Forgot to add name changed file

ae42e41

Add install command for python bindings

acefbb3

rebase fixes and fixed PvlKeywordTest

2f95124

more rebase fixes

0d3bab9

Updated core_recipe

0f05211

Fix latest release version

2ca81b1

conda-forge updates

6338ec1

more conda-forge updates

33ca10f

working conda-forge changes

9527cf7

Updated core preference files to match the base preference files

15d3a81

acpaquette force-pushed the new_pvl_core branch from 7b81765 to 15d3a81 Compare September 5, 2025 18:07

acpaquette added 2 commits September 9, 2025 10:30

Updated Blob tests and changed how Isis/TestPreferences are added to …

d77f781

…the build and install

Removed old blob tests

d3aef56

Removed blob unitTest in CmakeLists.txt

cbd926e

PVL Core #5717

Are you sure you want to change the base?

PVL Core #5717

Uh oh!

Conversation

amystamile-usgs commented Jan 29, 2025

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

amystamile-usgs commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

amystamile-usgs commented Apr 10, 2025

Uh oh!

github-actions bot commented Sep 3, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants