Fixes MacOS bundle serialization #5808
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5808". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
1 similar comment
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5808". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
| // cumulativeProbabilityDistribution().save(stream, project); | ||
| cumulativeProbabilityDistribution().save(stream, project); | ||
| stream.writeEndElement(); // end cumulativeProbabilityCalculator | ||
|
|
||
| stream.writeStartElement("residualsCumulativeProbabilityCalculator"); | ||
| // residualsCumulativeProbabilityDistribution().save(stream, project); |
There was a problem hiding this comment.
Hey @kledmundson, I was meaning to email you about this but figured I would ask you here. Was there a reason that these distributions were commented out of the bundle result serialization? If there is I can revert this change but it seemed weird that it was commented out
There was a problem hiding this comment.
Sadly, I can't recall why/when/how this was done. I agree that it doesn't make sense to be removed specifically from IPCE. That being said, I'm not sure we ever finished properly serializing an IPCE project. Just for kicks I grabbed your code, built it, and ran a bundle both from the command line and in IPCE. Got identical results as expected. Then tried to save the IPCE project and it crashed on me. Don't know why. Based on where we were when we had to stop, I'm not completely sure we had everything serialized properly. Have you tested this in IPCE? And been able to save and restore a project with a bundle in it?
There was a problem hiding this comment.
I have not but there is a test for bundle results serialization that was failing on Mac and this addresses it. With the commented outlines, the cumulativeProbabilityCalculator and residualsCumulativeProbabilityCalculator elements in the XML where empty causing issues when trying to read the serialized bundle results back in.
It doesn't surprise me that IPCE crashed while saving a bundle/project as we made a number of changes to the XML writing updating to qt 5.15. I just don't know if the crash existed prior to that XML change since IPCE isn't something we poke at regularly.
There was a problem hiding this comment.
Then, I would say go ahead and merge it if only to get the tests passing. We If IPCE ever lives again we'll want those stats to persist in the project and the serialization will have to be re-sorted out anyway.
acpaquette
force-pushed
the
bundle_serial_fix
branch
from
0480c42 to
8eee153
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5808". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
force-pushed
the
bundle_serial_fix
branch
from
8eee153 to
680ea82
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5808". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
chkim-usgs
left a comment
chkim-usgs
left a comment
There was a problem hiding this comment.
Resolve conflicts and should be good to go
acpaquette
force-pushed
the
bundle_serial_fix
branch
from
680ea82 to
42a07e2
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5808". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
3 participants
Description
Fixes MacOS bundle serialization for IPCE and adds back in the calculator tables
Related Issue
N/A
How Has This Been Validated?
Validated locally and through MacOS testing
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: