App Fixes For GeoTiffs #5824

acpaquette · 2025-05-30T21:38:38Z

Description

Fixes apps that fail when passing a GeoTiff with ISIS metadata

Related Issue

Fixes #5842
Fixes #5869

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2025-05-30T21:39:28Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-06-18T21:43:10Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-06-19T22:09:20Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-15T17:39:46Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-15T22:48:21Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-15T23:41:28Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-11-19T19:00:12Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-11-19T19:02:53Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-11-19T19:08:52Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-12-04T18:25:41Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-12-04T20:17:32Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-12-04T23:50:05Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Kelvinrr · 2025-12-10T19:50:29Z

I imagine the CH-2 test failures are unrelated.

Spiceinit on a GTIFF was fine.

CSMINIT gave an error

(isisgdalbuilds) igswza281l2305:isisbuild krodriguez$ ./bin/csminit from=~/cnets/I52634011RDR.tiff isd=~/cnets/I52634011RDR.json
**USER ERROR** No loaded model could be created from the ISD [/Users/krodriguez/cnets/I52634011RDR.json].Loaded plugin & model names:
Plugin [UsgsAstroPluginCSM], Model [USGS_ASTRO_FRAME_SENSOR_MODEL]
.
.
.

Kelvinrr · 2025-12-30T21:56:07Z

Problem seems to be from an unrelated bug.

Kelvinrr · 2025-12-30T21:56:57Z

Looks good, needs a changlog entry.

github-actions · 2025-12-30T22:47:57Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-12-31T19:42:42Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Kelvinrr · 2026-01-06T15:21:43Z

isis/src/base/objs/Cube/Cube.cpp

+    if (hDriver != nullptr) {
+        GDALDriver* poDriver = (GDALDriver*)hDriver;
+        QString driverDescription = poDriver->GetDescription();
+        openWithGdal = driverDescription == QString("GTiff");


Theoritically, with GDAL 3.12, could we GDAL translate to a PNG (or any other non-cube raster format) and still read in ISIS?

I reversed this, so instead of checking for a gtiff it now checks if the driver is not the "ISIS3" driver. So we will try to open it using the gdal control flow if it isn't an ISIS3 cube.

github-actions · 2026-01-06T17:43:51Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-01-06T22:09:42Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-01-07T18:21:23Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

… driver

…s cubes

… the ISIS3 driver

github-actions · 2026-01-07T22:39:07Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5824".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette force-pushed the gtiff_fixes branch from b019ba2 to db7096d Compare June 18, 2025 21:42

Kelvinrr marked this pull request as ready for review September 12, 2025 16:06

acpaquette force-pushed the gtiff_fixes branch from 6ed4fc5 to 05474e7 Compare September 15, 2025 17:39

acpaquette force-pushed the gtiff_fixes branch from 9a0ab75 to 120ee2b Compare November 19, 2025 18:59

acpaquette force-pushed the gtiff_fixes branch from ec18882 to 96a92d1 Compare December 4, 2025 18:23

acpaquette force-pushed the gtiff_fixes branch from 8bc6971 to adfb255 Compare December 30, 2025 22:47

acpaquette requested a review from Kelvinrr December 31, 2025 21:00

Kelvinrr reviewed Jan 6, 2026

View reviewed changes

acpaquette force-pushed the gtiff_fixes branch from bd1ec61 to a3a536a Compare January 6, 2026 17:43

Fixes apps that fail when passing a GeoTiff with ISIS metadata

f4b5c11

acpaquette added 24 commits January 7, 2026 15:37

Fixed serial number composition to handle Gtiffs

fd524c8

Fix csminit on GeoTiff in ISIS

3e4f8c8

Add try catch around check for json blob

9bd9141

Remove error throw from gdalDataset and change json blob detection

98bf500

Move gdal label reading from Cube into the Pvl class

0ed7e7b

Revert autoseed and serialnumber label read changes

6e89633

Revert other apps that read pvl labels

570db5e

Remove try catch around read from debugging

ef3f33c

Reverted serialnumber compose to access the label directly

b77887d

Revert more label reads

3289213

Fixed throw in PVL class at the end contructor from file path

3ba7252

Update opencv to use the cmake config

45f4ff6

Fix using opencv config for find_package

9b2d4b8

Fixed error throwing in Pvl contruction

73b72c8

Fixed other tests with new errors and label size change

d1228e5

Decide to open a cube using gdal or ISIS open logic based on the GDAL…

b73568c

… driver

Added changelog entry

00777c0

Fix tests after changing how cube decides to open files as geotiffs v…

382d527

…s cubes

Handle gdal metadata pointer comparison change

2de9a13

Change geotiff creation to default to .tif

dd609bd

Fix ecub creation

bfa49b2

Changed check for using gdal to open images if the driver used is not…

da4b734

… the ISIS3 driver

Fixed gdal metadata check to read metadata if it is NOT a nullptr

65882a2

Handle ISIS2 and ISIS3 gdal drivers when opening images

7cde20c

acpaquette force-pushed the gtiff_fixes branch from b522714 to 7cde20c Compare January 7, 2026 22:38

Kelvinrr approved these changes Jan 7, 2026

View reviewed changes

Kelvinrr merged commit 3546b33 into DOI-USGS:dev Jan 7, 2026
3 checks passed

github-actions bot added bug Something isn't working inactive Issue that has been inactive for at least 6 months labels Jan 7, 2026

App Fixes For GeoTiffs #5824

App Fixes For GeoTiffs #5824

Uh oh!

Conversation

acpaquette commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

github-actions bot commented Sep 15, 2025

Uh oh!

github-actions bot commented Sep 15, 2025

Uh oh!

github-actions bot commented Sep 15, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

Kelvinrr commented Dec 10, 2025

Uh oh!

Kelvinrr commented Dec 30, 2025

Uh oh!

Kelvinrr commented Dec 30, 2025

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

Kelvinrr Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

acpaquette Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

acpaquette commented May 30, 2025 •

edited

Loading