Skip to content

fixed old todo, with getenv #5906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fixed old todo, with getenv #5906

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5442fd
fixed old todo, with getenv
jrcain-usgs Nov 25, 2025
0379b8e
add spiceql cache dir
jrcain-usgs Dec 1, 2025
387fb9d
init env var c command changelog entry
jrcain-usgs Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 8 additions & 33 deletions isis/src/base/objs/Application/Application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,46 +976,21 @@ namespace Isis {
}

/**
* Runs some printenv commands that return Isis related Enviroment Variables.
* Returns ISIS-related Enviroment Variables.
*
* @return PvlGroup containing Enviroment information
* @todo Replace printenv commands with c library getenv
* @todo
*/
PvlGroup Application::GetEnviromentInfo() {
// Create a temporary file to store console output to
FileName temp = FileName::createTempFile("$temporary/EnviromentInfo.txt");
QString tempFile = temp.expanded();

PvlGroup envGroup("EnviromentVariables");
ifstream readTemp;

QString env1 = "printenv SHELL >| " + tempFile;
QString env2 = "printenv HOME >> " + tempFile;
QString env3 = "printenv PWD >> " + tempFile;
QString env5 = "printenv ISISROOT >> " + tempFile;
QString env6 = "printenv ISISDATA >> " + tempFile;
ProgramLauncher::RunSystemCommand(env1);
ProgramLauncher::RunSystemCommand(env2);
ProgramLauncher::RunSystemCommand(env3);
ProgramLauncher::RunSystemCommand(env5);
ProgramLauncher::RunSystemCommand(env6);
// Read data from temp file
char value[511];
readTemp.open(tempFile.toLatin1().data(), ifstream::in);
readTemp.getline(value, 255);
envGroup.addKeyword(PvlKeyword("Shell", value));
readTemp.getline(value, 255);
envGroup.addKeyword(PvlKeyword("Home", value));
readTemp.getline(value, 255);
envGroup.addKeyword(PvlKeyword("Pwd", value));
readTemp.getline(value, 255);
envGroup.addKeyword(PvlKeyword("ISISROOT", value));
readTemp.getline(value, 255);
envGroup.addKeyword(PvlKeyword("ISISDATA", value));
envGroup.addKeyword(PvlKeyword("Shell", getenv("SHELL")));
envGroup.addKeyword(PvlKeyword("Home", getenv("HOME")));
envGroup.addKeyword(PvlKeyword("PWD", getenv("PWD")));
envGroup.addKeyword(PvlKeyword("ISISROOT", getenv("ISISROOT")));
envGroup.addKeyword(PvlKeyword("ISISDATA", getenv("ISISDATA")));
envGroup.addKeyword(PvlKeyword("SPICEQL_CACHE_DIR", getenv("SPICEQL_CACHE_DIR")));

// remove temp file and return
QString cleanup = "rm -f " + tempFile;
ProgramLauncher::RunSystemCommand(cleanup);
return envGroup;
}

Expand Down