Skip to content

Added csm sandbox #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

jrcain-usgs
Copy link
Contributor

@jrcain-usgs jrcain-usgs commented Feb 26, 2025

Licensing

Fixes #110

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jrcain-usgs jrcain-usgs marked this pull request as ready for review February 27, 2025 23:55
@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Mar 7, 2025

Looks good so far, but we need an easy way to download or run these online. Otherwise it's kind of a pain. I'll look into some things this weekend.

@jrcain-usgs
Copy link
Contributor Author

need an easy way to download or run these online. Otherwise it's kind of a pain.

Unless that applies to this notebook specifically, easy downloads/online interactivity should be a separate issue.

This notebook (PR 120) has also been waiting quite a while to be updated, and delayed I think for similar reasons.

@Kelvinrr
Copy link
Collaborator

@jrcain-usgs I think short term, we can add the download button. jupyterlite seem promising. but only works for no arch libraries, most of our libraries need to be compiled since they contain wrappers to C++ binaries.

Copy link
Collaborator

@Kelvinrr Kelvinrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, I spent a lot of time playing with it which makes me happy that I will fulfill the purpose I was hoping it would.

Some suggestions in line.

" 'focal_length_model': {'focal_length': 352.9271664 + fl_add},\n",
" 'detector_center': {'line': 0.430442527 + dcl_add, 'sample': 2542.96099 + dcs_add},\n",
" 'optical_distortion': {'radial': {'coefficients': [-0.007343 + opt_x, 2.838e-05 + opt_y, 1.284e-08 + opt_z]}},\n",
" 'center_ephemeris_time': 297088762.2425226 + ect_add\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this slider is good, but this is changing there center time, not exposure time. Exposure time is part of the line_scan_rate.

Additionally, might be worth adding sliders or changing values in focal2pixel_lines and focal2pixel_samples

"camera = csm.create_csm(isd_file)\n",
"\n",
"# Get the footprint using the model\n",
"boundary = csm.generate_boundary((isd_dict[\"image_lines\"], isd_dict[\"image_samples\"]))\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this ISD was 1x1 pixel. It would be better to do something that is full sample length with cropped lines. Especially since this is a CTX camera.

Comment on lines 4 to 13
"cell_type": "markdown",
"metadata": {},
"source": [
"# CSM Sandbox\n",
"\n",
"## 1. Prerequisites\n",
"\n",
"### Install Knoten\n",
"This tutorial requires Knoten version 0.4 or higher.\n",
"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the ISD to be a full CTX ISD, then add an explanation that this is a CTX, line scanner image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSM Camera sandbox
2 participants