Continuous #832
Open
Continuous #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldecicco-USGS
temporarily deployed
to
CI_config
GitHub Actions
Inactive
ldecicco-USGS
temporarily deployed
to
CI_config
GitHub Actions
Inactive
ldecicco-USGS
had a problem deploying
to
CI_config
GitHub Actions
Failure
ldecicco-USGS
temporarily deployed
to
CI_config
GitHub Actions
Inactive
ldecicco-USGS
temporarily deployed
to
CI_config
GitHub Actions
Inactive
Collaborator
|
Hey there, I have time to review Wed/Thur. |
ldecicco-USGS
temporarily deployed
to
CI_config
GitHub Actions
Inactive
ldecicco-USGS
temporarily deployed
to
CI_config
GitHub Actions
Inactive
ehinman
reviewed
Dec 3, 2025
| #' @export | ||
| #' @param monitoring_location_id `r get_params("continuous")$monitoring_location_id` | ||
| #' @param parameter_code `r get_params("continuous")$parameter_code` | ||
| #' @param statistic_id `r get_params("continuous")$statistic_id` |
Collaborator
There was a problem hiding this comment.
Note to self to test: is this really a valid input? Isn't the stat id for continuous 00011?
ehinman
reviewed
Dec 3, 2025
| } | ||
| # leave some room here for POSIXct in the other services. | ||
| } | ||
| # by default, the data is put in POSITct and seems |
Collaborator
There was a problem hiding this comment.
Suggested change
| # by default, the data is put in POSITct and seems | |
| # by default, the data is put in POSIXct and seems |
ehinman
reviewed
Dec 3, 2025
| ``` | ||
| GET: https://nwis.waterservices.usgs.gov/nwis/iv/?site=11455508&format=waterml%2C1.1&ParameterCd=99133&startDT=2024-01-01&endDT=2024-06-01 | ||
| Requesting: | ||
| https://api.waterdata.usgs.gov/ogcapi/v0/collections/continuous/items?f=json&lang=en-US&skipGeometry=TRUE&limit=40000&monitoring_location_id=USGS-11455508¶meter_code=99133&time=2024-01-01T00%3A00%3A00Z%2F2024-06-01T00%3A00%3A00Z |
Collaborator
There was a problem hiding this comment.
Suggested change
| https://api.waterdata.usgs.gov/ogcapi/v0/collections/continuous/items?f=json&lang=en-US&skipGeometry=TRUE&limit=40000&monitoring_location_id=USGS-11455508¶meter_code=99133&time=2024-01-01T00%3A00%3A00Z%2F2024-06-01T00%3A00%3A00Z | |
| https://api.waterdata.usgs.gov/ogcapi/v0/collections/continuous/items?f=json&lang=en-US&skipGeometry=TRUE&limit=50000&monitoring_location_id=USGS-11455508¶meter_code=99133&time=2024-01-01T00%3A00%3A00Z%2F2024-06-01T00%3A00%3A00Z |
Looking at this without context but should it be 50000?
ehinman
reviewed
Dec 3, 2025
| this_week <- read_waterdata_continuous(monitoring_location_id = c("USGS-05406457", | ||
| "USGS-05427930"), | ||
| parameter_code = c("00060", "00010"), | ||
| time = "P7D") |
ehinman
reviewed
Dec 3, 2025
| These data are the discrete measurements of discharge that are made for the purpose of developing or revising the rating curve. Information on the returned data can be found with the `comment` function and attached attributes as described in the [metadata](#embedded-metadata) section. | ||
|
|
||
| Surface-water measurement data can be obtained with the `readNWISmeas` function. | ||
| Surface-water measurement data can be obtained with the `read_waterdata_field_measurements`` function. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Surface-water measurement data can be obtained with the `read_waterdata_field_measurements`` function. | |
| Surface-water measurement data can be obtained with the `read_waterdata_field_measurements` function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.