-
Notifications
You must be signed in to change notification settings - Fork 5
Vue3 update and new domain setup #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this, Cee. This is a trickier one to convert. It may make sense to use the original url for the upcoming re-release, unless you have time to address the issues noted below.
I've pushed a few minor edits to keep things consistent w/ other repos.
I didn't have time at the moment to dig into the details of the changes is src/components/DroughtHistory.vue, but there were enough apparent issues based on the test site that I'm requesting changes upfront. I think the desktop version is almost there. The mobile version needs a lot of work.
General:
- RC: timeline buttons should have white background, not grey
Desktop:
- RC: fix map image in upper right - is currently doubled:
- In "Drought in Regions of the Conterminous U.S." section,
- RC: drop black border on svg wedges:
- RC: when mouse moves off of svg, return to default state with all violins shown at full opacity
- RC: reduce size of central map:
Mobile
- RC: drop font size to 16 px (1.6rem), instead of 20 px (2rem)
- RC: fix display on load. Currently first paragraph and buttons overflow and overlap bottom panel, possibly just because of font size
- RC: fix display of all annotations. Currently text does not appear in bottom panel throughout site
- RC: Make the map in the upper right stick and ensure updates correctly
- RC: Fix vertical time axis labels and sizing of timeline points - both are too small on mobile (see above screenshot noting lack of annotations)
- RC: Fix mobile implementation of violin plots - it is completely broken at the moment
Co-authored-by: Hayley Corson-Dosch <[email protected]>
Co-authored-by: Hayley Corson-Dosch <[email protected]>
Co-authored-by: Hayley Corson-Dosch <[email protected]>
Co-authored-by: Hayley Corson-Dosch <[email protected]>
Co-authored-by: Hayley Corson-Dosch <[email protected]>
Co-authored-by: Hayley Corson-Dosch <[email protected]>
Co-authored-by: Hayley Corson-Dosch <[email protected]>
|
@hcorson-dosch-usgs ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going back through and addressing things. A few remaining items:
Desktop:
- RC: have default font size be
2rem(20px), not 16px - In regional section:
- RC: make center map smaller. it's obscuring data
- RC: when user stops hovering over chart, make all wedges fully transparent so that all violins are shown.
Mobile:
- Fix vertical time axis labels and sizing of timeline points - both are still too small on mobile
- Reduce top margin of map on stick - currently floats a little too far below the buttons when you scroll - makes it feel randomly placed
- 'Drought in Regions of the Conterminous U.S.' section
- Add the updating regional title
- Fix the selection for the Southeast U.S. - currently map is not highlighted






Description
Update of website from Vue 2 to Vue 3, including updates to vue components to be consistent with current vue 3 website template, and new domain setup for water.usgs.gov/vizlab
Changes Made
VITE_APP_ASSET_URLenvironment variable that depends on the build tierVITE_APP_S3_PROD_URL environment variable pointing to the CloudFront url for our prod bucket on s3VITE_APP_S3_PROD_URLenvironment variablerequirewere replaced with agetImageUrlfunctionDrourghtHistory.vuetemplate to differentiate moble and desktop elements; element ids updated to reflect this and correct some unintended duplication of elements in the DOMApp.vueto assets and simplifiedI did not touch the data pipeline
How to Test
Compare local build to published site at https://labs.waterdata.usgs.gov/visualizations/drought-timeline/index.html#/
Ensure that site functions the same, or better, than existing site, and that site appearance is consistent. Visual changes to the site should only exist for required VisID (e.g. added USGS footer). Verify gsap scrolling timeline works as expected. There were breaking changes with dependency updates which required some reworking of the scroll setup.
Should be tested thoroughly on mobile as well
MR t-shirt size
Timeline for review
Review Needs
Does this MR include data processing, modeling, or visualization code that will require domain review prior to release?
DomainReviewissue templateRelated Issues
Provide links to any related issues, including open draft domain review issues.
Additional Notes
Include any extra information or considerations for reviewers.
Merge Request Checklists
README.mdnpm run lint