Also show memory limit for samples on team submission page#3302
Also show memory limit for samples on team submission page#3302nickygerritsen wants to merge 2 commits into
Conversation
This was requested at SEERC and I think it makes sense in general. Also updated the logic to only show these limits when `show_limits_on_team_page` is set.
Algotester does this so we needed it for SEERC and I think having this as an option can make sense.
| <th>Runtime</th> | ||
| <td>{{ judgingRun.runtime }} sec</td> | ||
| </tr> | ||
| {% if showLimits %} |
There was a problem hiding this comment.
I prefer to not have this option, and first come up with a good reason why this shouldn´t be public.
If there is a good reason we should also add tests for this to make sure that we don´t expose that information, for now I miss the change to also expose this in the API to keep those in line.
There was a problem hiding this comment.
I'm fine always doing it but if we have that setting for limits turned of I think it's weird.
As for the API, I'm fine adding the memory limit there as well
|
Can you please add a before/after screenshot? |
|
Before if all sample tests have been run: Before if not: After with the default settings, when not all sample testcases are run: After with showing limits off: After with showing limits on AND showing results for all testcases on: |
I wonder if a graph with 2 y-axis & the limit would be even better, as we also have in the jury interface. I can look at that myself in another PR. |
| public: true | ||
| description: | | ||
| Show verdicts for all testcases on the team interface. | ||
| If `show_limits_on_team_page` is also set, also display runtime and memory usage. |
There was a problem hiding this comment.
I find the implication of exposing actual usage when selecting the option "show limits" (as in upper bounds) quite confusing.
There was a problem hiding this comment.
What is your suggestion? Always showing time/memory limit for samples/testcases (like we do now) if you enable those options or adding yet another option to show these limits?
3 participants
I'm open to discussing these changes, since they might not be preferred by everyone.
I am in favor of the first change for sure (since teams could measure this on their own machine anyway). The second might be more controversial.