-
Notifications
You must be signed in to change notification settings - Fork 5
Sketch: e2e rspec tests #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jeffcatania-usds
wants to merge
19
commits into
main
Choose a base branch
from
jeffcatania-usds/e2e-rspec-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outstanding work left:
|
the e2e folder doesnt run anywhere so TODO but to start cleaning up cbv flow test to actually pass. shared examples are mostly an antipattern when it comes to debugging, we should DRY another way if we want. that being said, starting with not thinking about internalization seemed like the stronger start here.
this attempts to simulate a full end to end test suite with as much simulation as possible. two annoying bits of simulation 1) webhooks are not easily simulateable due to the authorization signing key. Debating whether a refactor of webhooks controller or an attempt to better simulate the signing a wiser attempt. 2) puffing billy does not play nice with the fact all the step javascript calls are timestamped. to get around this, we have to be a bit more manual in our puffing billy simulation.
6b9c3dd
to
531e794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-2687
TODOS
Changes
Context for reviewers
To re-record mocks, flip RECORD_OPTION in app/spec/e2e/cbv_flow_spec.rb to "all" if you need to record a new interaction
to run these tests with record: :all, make sure you have a .env.test.local with PINWHEEL_API_TOKEN_SANDBOX, then you can run this test via running
to run these tests at all, explicitly via rubymine, or RUN_E2E_TESTS=1 bundle exec rspec spec/e2e/cbb_flow_spec.rb.
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!
)