Landing Page: Added new landing page!!! #301
Conversation
Signed-off-by: Natalia Luzuriaga <[email protected]>
natalialuzuriaga
requested review from
DinneK,
IsaacMilarky,
decause-gov and
sachin-panayil
sachin-panayil
left a comment
sachin-panayil
left a comment
There was a problem hiding this comment.
This is great work Nat! All my suggestions are NIT and this could be merged without any of the additions tbh. Really cool work of using the SHARE IT Act LP as a base and building/expanding from it 💯
landing-page/index.html
Outdated
| <!-- Hero Section --> | ||
| <section class="hero" id="hero"> | ||
| <div class="container"> | ||
| <h1>Creating Open Source Projects in CMS' Open Source ecosystem</h1> |
There was a problem hiding this comment.
Capitalize E in ecosystem
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title> repo-scaffolder | Centers for Medicare & Medicaid Services </title> |
| </tbody> | ||
| </table> | ||
| </div> | ||
| <!-- Tier Determiner Quiz --> |
There was a problem hiding this comment.
this is so clean, im stealing this for suuuure 🔥
| <tbody> | ||
| <tr> | ||
| <th scope="row">LICENSE</th> | ||
| <td>Defines the licensing terms under which the project is distributed.</td> |
There was a problem hiding this comment.
NIT: having the color coding here would make readability nicer
| <script src="https://cdnjs.cloudflare.com/ajax/libs/uswds/3.6.1/js/uswds.min.js" defer></script> | ||
| </head> | ||
| <body> | ||
| <!-- Feedback Banner --> |
There was a problem hiding this comment.
also taking this for the SHARE IT landing page 🔥
| <span class="icon-bar"></span> | ||
| </button> | ||
| <ul id="main-menu"> | ||
| <li><a href="#hero" aria-current="page">Home</a></li> |
There was a problem hiding this comment.
I have to fix the bug where the navbar focus state doesnt work. it broke because i had to get rid of the government website banner but when i do fix it, i will send you the code
Signed-off-by: Natalia Luzuriaga <[email protected]>
decause-gov
left a comment
decause-gov
left a comment
There was a problem hiding this comment.
This is wayyyy better than a simple README! LGTM +1 🚢
Landing Page: Added new landing page!!!
Problem
repo-scaffolder is a complex tool that contains various tools and processes developed by the OSPO. We would like to create a landing page that explains repo-scaffolder and clearly connects the dots between all its suite of tools.
Solution
Contains 3 major sections:
Result
Test Plan
Run
python3 -m http.server 8000in thelanding-pagedirectoryWhen we ship to main, I'll set up GitHub pages by hosting on the
landing-pagedirectory