Skip to content

fix: WorkitemsSingleGetResponseDataRelationshipsApprovalsDataItemType missing option #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Apr 3, 2025

Somehow in relationships there can be workitem_approvals included. This is missing in the enum data type.

…e` missing option

Somehow in relationships there can be workitem_approvals included. This is missing in the enum data type.
Copy link
Member Author

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger requested a review from micha91 April 3, 2025 10:41
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to regenerate the code using the latest spec? We should avoid manual adjustments of auto generated code

@ewuerger
Copy link
Member Author

Did you try to regenerate the code using the latest spec? We should avoid manual adjustments of auto generated code

Yes, but this is still not covered and additionally for me the template for generating the api doesn't work anymore until I remove multipart from model.py.jinja. And this is actually useful and breaks the API in the end. In order to cover this bug, we'd still need this PR to get merged. :(

@ewuerger
Copy link
Member Author

ewuerger commented May 9, 2025

Leave this PR open until I validated that the updated client is working just like this one.

@ewuerger ewuerger marked this pull request as draft May 9, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants