Bugfix-#2383-audio-trapped-in-output-buffer-of-resampler#2384
Open
Randesign wants to merge 1 commit intoDSheirer:masterfrom
Open
Bugfix-#2383-audio-trapped-in-output-buffer-of-resampler#2384Randesign wants to merge 1 commit intoDSheirer:masterfrom
Randesign wants to merge 1 commit intoDSheirer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2383.
Resampler already implements a lastBatch parameter, which will pad the unused portion of the input buffer with zeros. Extended that function to the output buffer to be sure no audio samples are left in the buffer.
The RealResampler is used by a number of functions in SDRTrunk.
Tested with:
MP3 resampling
NBFM/noiseSquelch decoding
AM demodulator will be left as is for now. I would like to address resampler issues and other issues in #2301 at a later date.
AFSK1200: I have no way to test this.