Skip to content

add definition lists for income terms #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

remy-mazerolle-esdc
Copy link
Contributor

Summary

adds dl/dt/dd for income terms in field infos to improve screen reader support

Types of changes

What types of changes does this PR introduce?
(check all that apply by placing an x in the relevant boxes)

  • 🛠️ refactoring -- non-breaking change that improves code readability or structure
  • 🐛 bugfix -- non-breaking change that fixes an issue
  • new feature -- non-breaking change that adds functionality
  • 💥 breaking change -- change that causes existing functionality to no longer work as expected
  • 📚 documentation -- changes to documentation only
  • ⚙️ build or tooling -- ex: CI/CD, dependency upgrades

Checklist

Before submitting this PR, ensure that you have completed the following. You can fill these out now, or after creating the PR.
(check all that apply by placing an x in the relevant boxes)

  • code has been linted and formatted locally
  • added or updated tests to verify the changes
  • added adequate logging for new or updated functionality
  • ensured metrics and/or tracing are in place for monitoring and debugging
  • documentation has been updated to reflect the changes (if applicable)
  • linked this PR to a related issue (if applicable)
Linting and formatting
npm run lint:check
npm run format:check
Unit and e2e tests
npm run test
npm run test:e2e

@remy-mazerolle-esdc remy-mazerolle-esdc force-pushed the add-def-list-income-terms branch from 013d84f to 077f0fa Compare April 23, 2025 17:11
@remy-mazerolle-esdc remy-mazerolle-esdc enabled auto-merge (squash) April 23, 2025 17:12
@remy-mazerolle-esdc remy-mazerolle-esdc merged commit a1b3d60 into main Apr 23, 2025
3 checks passed
@remy-mazerolle-esdc remy-mazerolle-esdc deleted the add-def-list-income-terms branch April 23, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants