Skip to content

fix(frontend) fix heading structure #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ken-blanchard wants to merge 1 commit into from
Closed

fix(frontend) fix heading structure #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/app/routes/estimator/step-income.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,12 @@ export default function StepIncome({ actionData, loaderData, matches, params }:
<FetcherErrorSummary fetcherKey={fetcherKey}>
<fetcher.Form method="post" noValidate>
<div className="space-y-6">
<h2>
<p>
{isMarried
? t('estimator:income.form-instructions.married', { year: previousIncomeTaxReturnYear })
: t('estimator:income.form-instructions.single', { year: previousIncomeTaxReturnYear })}
</h2>
<h3 className="font-lato mb-4 text-2xl font-bold">{t('estimator:income.heading.your-info')}</h3>
</p>
<h2 className="font-lato mb-4 text-2xl font-bold">{t('estimator:income.heading.your-info')}</h2>
<CurrencyField
name="individual-net-income"
label={t('estimator:income.fields.net-income.label')}
Expand Down Expand Up @@ -321,7 +321,7 @@ export default function StepIncome({ actionData, loaderData, matches, params }:

{isMarried && (
<>
<h3 className="font-lato mb-4 text-2xl font-bold">{t('estimator:income.heading.partner-info')}</h3>
<h2 className="font-lato mb-4 text-2xl font-bold">{t('estimator:income.heading.partner-info')}</h2>
<CurrencyField
name="partner-net-income"
label={t('estimator:income.fields.partner.net-income.label')}
Expand Down
10 changes: 3 additions & 7 deletions ...timator/step-income.spec.ts/Navigating-to-en-income-renders-the-english-income-page-1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
<div>
<form novalidate="" data-discover="true" action="/en/income" method="post">
<div class="space-y-6">
<h2>
<p>
To estimate your benefits, we will need the following information from
your 2024 tax return:
</h2>
<h3 class="font-lato mb-4 text-2xl font-bold">Your information</h3>
</p>
<h2 class="font-lato mb-4 text-2xl font-bold">Your information</h2>
<div id="input-text-field-«Rdmlj5»" class="space-y-2">
<label class="block" id="input-text-field-«Rdmlj5»-label"
><span class="font-semibold">Your net income</span></label
Expand Down Expand Up @@ -63,7 +63,6 @@
autocomplete="off"
name="individual-net-income"
value=""
inputmode="numeric"
/>
</div>
<div id="input-text-field-«Rhmlj5»" class="space-y-2">
Expand Down Expand Up @@ -141,7 +140,6 @@
autocomplete="off"
name="individual-working-income"
value=""
inputmode="numeric"
/>
</div>
<div id="input-text-field-«Rlmlj5»" class="space-y-2">
Expand Down Expand Up @@ -210,7 +208,6 @@
autocomplete="off"
name="individual-claimed-income"
value=""
inputmode="numeric"
/>
</div>
<div id="input-text-field-«Rpmlj5»" class="space-y-2">
Expand Down Expand Up @@ -279,7 +276,6 @@
autocomplete="off"
name="individual-claimed-repayment"
value=""
inputmode="numeric"
/>
</div>
</div>
Expand Down
10 changes: 3 additions & 7 deletions ...timator/step-income.spec.ts/Navigating-to-fr-revenus-renders-the-french-income-page-1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
<div>
<form novalidate="" data-discover="true" action="/fr/revenus" method="post">
<div class="space-y-6">
<h2>
<p>
Pour estimer vos prestations, nous aurons besoin des renseignements
suivants de votre déclaration de revenus de 2024.
</h2>
<h3 class="font-lato mb-4 text-2xl font-bold">Votre information</h3>
</p>
<h2 class="font-lato mb-4 text-2xl font-bold">Votre information</h2>
<div id="input-text-field-«Rdmlj5»" class="space-y-2">
<label class="block" id="input-text-field-«Rdmlj5»-label"
><span class="font-semibold">Votre revenu net</span></label
Expand Down Expand Up @@ -64,7 +64,6 @@
autocomplete="off"
name="individual-net-income"
value=""
inputmode="numeric"
/><span class="ml-1">$</span>
</div>
<div id="input-text-field-«Rhmlj5»" class="space-y-2">
Expand Down Expand Up @@ -142,7 +141,6 @@
autocomplete="off"
name="individual-working-income"
value=""
inputmode="numeric"
/><span class="ml-1">$</span>
</div>
<div id="input-text-field-«Rlmlj5»" class="space-y-2">
Expand Down Expand Up @@ -217,7 +215,6 @@
autocomplete="off"
name="individual-claimed-income"
value=""
inputmode="numeric"
/><span class="ml-1">$</span>
</div>
<div id="input-text-field-«Rpmlj5»" class="space-y-2">
Expand Down Expand Up @@ -292,7 +289,6 @@
autocomplete="off"
name="individual-claimed-repayment"
value=""
inputmode="numeric"
/><span class="ml-1">$</span>
</div>
</div>
Expand Down
Loading