-
-
Notifications
You must be signed in to change notification settings - Fork 437
Timeline introduced #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
e8defb2
initial implementation
DaKheera47 f28d6d3
onboarding doesn't pop until invalid values are present
DaKheera47 dc501b9
link to job page
DaKheera47 a2c2b99
proactive inputs working slightly
DaKheera47 c625a4e
onboarding gate reinstated
DaKheera47 88ee5de
better proactive buttons
DaKheera47 4e24199
fully manual tracking for now.
DaKheera47 f3e02e6
edit and delete timeline events
DaKheera47 f7e8415
status showing correctly
DaKheera47 9e4c93f
tests update
DaKheera47 fd4b1d4
tests
DaKheera47 3d51ac7
Update orchestrator/src/server/services/applicationTracking.ts
DaKheera47 31be173
Update orchestrator/src/server/services/applicationTracking.test.ts
DaKheera47 33b44f6
Update orchestrator/src/server/services/applicationTracking.test.ts
DaKheera47 d261dc0
Update orchestrator/src/client/pages/job/Timeline.tsx
DaKheera47 7fe9eeb
Update orchestrator/src/client/pages/JobPage.tsx
DaKheera47 fc6369d
add tests for application tracking routes and remove unused actionId …
DaKheera47 d3d6c2d
remove unnecessary await from synchronous transitionStage calls and i…
DaKheera47 621d10a
relax externalUrl validation to allow non-URL metadata
DaKheera47 bcca4f0
add toast notifications for data loading and event logging in JobPage
DaKheera47 2bbc4ec
comments
DaKheera47 204c234
Merge branch 'timeline-implementation' of https://github.com/DaKheera…
DaKheera47 eb020aa
chore: resolve merge conflicts in timeline-implementation
DaKheera47 5b139b5
fix: resolve type error in sponsor-matching.test.ts
DaKheera47 a8716f4
fix ci
DaKheera47 2939e36
tests fix for github
DaKheera47 2ae5169
lint
DaKheera47 0bd39c6
github comments
DaKheera47 83c0baa
build fix
DaKheera47 b721401
Merge branch 'main' into timeline-implementation
DaKheera47 7b190b0
dedupe
DaKheera47 63dd1fa
format
DaKheera47 86a6d7b
types fix
DaKheera47 f575f7e
Apply suggestion from @Copilot
DaKheera47 20a0c0b
formatting
DaKheera47 62dc5f6
Merge branch 'timeline-implementation' of https://github.com/DaKheera…
DaKheera47 0c4f43b
title and group id are discrete fields
DaKheera47 2171e52
backfill
DaKheera47 bbc643f
hide view button on page
DaKheera47 c765118
show relevant dropdown options
DaKheera47 51e4f4f
confetti!
DaKheera47 2dd6be0
remove redundant
DaKheera47 660a992
confirm delete is a custom element now
DaKheera47 22e6d16
formatting
DaKheera47 1e41ea0
fix styling
DaKheera47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import type React from "react"; | ||
| import { | ||
| AlertDialog, | ||
| AlertDialogAction, | ||
| AlertDialogCancel, | ||
| AlertDialogContent, | ||
| AlertDialogDescription, | ||
| AlertDialogFooter, | ||
| AlertDialogHeader, | ||
| AlertDialogTitle, | ||
| } from "@/components/ui/alert-dialog"; | ||
|
|
||
| interface ConfirmDeleteProps { | ||
| isOpen: boolean; | ||
| onClose: () => void; | ||
| onConfirm: () => void; | ||
| title?: string; | ||
| description?: string; | ||
| } | ||
|
|
||
| export const ConfirmDelete: React.FC<ConfirmDeleteProps> = ({ | ||
| isOpen, | ||
| onClose, | ||
| onConfirm, | ||
| title = "Are you sure?", | ||
| description = "This action cannot be undone. This will permanently delete this event from the timeline.", | ||
| }) => { | ||
| return ( | ||
| <AlertDialog open={isOpen} onOpenChange={(open) => !open && onClose()}> | ||
| <AlertDialogContent> | ||
| <AlertDialogHeader> | ||
| <AlertDialogTitle>{title}</AlertDialogTitle> | ||
| <AlertDialogDescription>{description}</AlertDialogDescription> | ||
| </AlertDialogHeader> | ||
| <AlertDialogFooter> | ||
| <AlertDialogCancel onClick={onClose}>Cancel</AlertDialogCancel> | ||
| <AlertDialogAction | ||
| onClick={() => { | ||
| onConfirm(); | ||
| onClose(); | ||
| }} | ||
| className="bg-destructive text-destructive-foreground hover:bg-destructive/90" | ||
| > | ||
| Delete | ||
| </AlertDialogAction> | ||
| </AlertDialogFooter> | ||
| </AlertDialogContent> | ||
| </AlertDialog> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.