feat: add congratulatory balloons and confetti on job offer stage transition#619
Open
Mr-Nobody1 wants to merge 5 commits into
Open
feat: add congratulatory balloons and confetti on job offer stage transition#619Mr-Nobody1 wants to merge 5 commits into
Mr-Nobody1 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR centralizes the “offer celebration” UI effect into a reusable client helper, updates pages/tests to use it, and makes the Typst template path tests Windows-path-safe.
Changes:
- Normalize Typst template-path assertions to be cross-platform (Windows vs POSIX separators).
- Introduce
celebrateOffer()helper and replace inlinecanvas-confetticalls in client pages. - Update client tests/docs to align with the new celebration helper and document the effect.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| orchestrator/src/server/services/resume-renderer/typst.test.ts | Normalizes path separators before asserting template paths. |
| orchestrator/src/client/pages/JobPage.tsx | Replaces inline confetti logic with celebrateOffer(). |
| orchestrator/src/client/pages/JobPage.test.tsx | Mocks the new celebration helper for test stability. |
| orchestrator/src/client/pages/InProgressBoardPage.tsx | Uses celebrateOffer() for offer-stage transitions (including DnD path). |
| orchestrator/src/client/pages/InProgressBoardPage.test.tsx | Updates mocks from canvas-confetti to celebrateOffer(). |
| orchestrator/src/client/lib/celebrate.ts | Adds a new reusable celebration implementation (confetti + balloons). |
| docs-site/docs/features/in-progress-board.md | Documents the celebration effect on Offer transitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+15
| export function celebrateOffer() { | ||
| // 1. Primary confetti burst from the middle/bottom area | ||
| confetti({ | ||
| particleCount: 140, | ||
| spread: 90, | ||
| origin: { y: 0.6 }, | ||
| zIndex: 999999, | ||
| colors: ["#10b981", "#34d399", "#6ee7b7", "#3b82f6", "#f59e0b", "#ec4899", "#a855f7"], | ||
| }); |
| origin: { y: 0.6 }, | ||
| colors: ["#10b981", "#34d399", "#6ee7b7", "#ffffff"], | ||
| }); | ||
| celebrateOffer(); |
Comment on lines
+1
to
+6
| --- | ||
| id: in-progress-board | ||
| title: In Progress Board | ||
| description: Post-application kanban board for tracking fewer, higher-attention jobs through interview and offer stages. | ||
| sidebar_position: 3 | ||
| --- |
|
|
||
| it("exposes the bundled Typst template", async () => { | ||
| expect(getTypstTemplatePath()).toContain("typst-themes/classic/main.typ"); | ||
| expect(getTypstTemplatePath().replace(/\\/g, "/")).toContain("typst-themes/classic/main.typ"); |
| expect(manifest.tokens).toBeUndefined(); | ||
| } | ||
| expect(getTypstTemplatePath(theme)).toContain( | ||
| expect(getTypstTemplatePath(theme).replace(/\\/g, "/")).toContain( |
Contributor
Author
|
omg, every time. @DaKheera47 Do you think user setting for this is needed? |
added 3 commits
June 12, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a small silly animation when you finally get a Offer!