Cvar migration: server #1626
Open
Cvar migration: server #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sv_maxclients migration commit got rid of that exception.
This was an extremely primitive mechanism which, if enabled, limited clients to one command per 800 milliseconds (hardcoded value). Get rid of it it so that no one will confuse it with the actually usable flood limiting in the sgame.
No functional change except for 2 numbers that shouldn't ever be used: bot initial rate (only until userinfo is parsed), and default rate for client with missing "rate" in userinfo.
Also make negative rate limit behave the same as 0 (i.e. unlimited)
Log cvar is logs.level.server.bandwidth
We need to be careful with this one: I changed the type to bool, but the string representation must still be "0"/"1" for gamelogic compat.
slipher
force-pushed
the
cvarmigrate-server
branch
from
816e6a6 to
d59478f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate all server cvars (
sv_), other thansv_killserver. (That one I want to NUKE later.)