-
Notifications
You must be signed in to change notification settings - Fork 5
Add kebab menus for session/window/pane actions in sidebar #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guysmoilov
wants to merge
3
commits into
main
Choose a base branch
from
claude/implement-kebab-menu-8ev2g
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
tmux break-pane -s vs -t flag source pane documentation💡 Result:
In
tmux break-pane:-s src-panespecifies the source pane to break out (the pane you are moving into its own window). If omitted, tmux uses the current pane. Thesrc-paneis addressed likesession:window.pane(for example:break-pane -s Advanced:1.2). [1][2]-t dst-windowspecifies the destination window (the window that will contain the broken-out pane as its only pane). If omitted, tmux creates a new window (at the next available index) for the pane. [1]Version note: older tmux versions used
-t target-pane(without-s); newer versions split this into-s src-paneand-t dst-window. [2]Sources:
[1] tmux man page (
break-pane ... [-s src-pane] [-t dst-window]) https://linuxcommand.org/lc3_man_pages/tmux1.html[2]
tmux_interfacedocs quoting tmux manuals across versions https://docs.rs/tmux_interface/latest/tmux_interface/commands/windows_and_panes/break_pane/struct.BreakPane.htmlUse
-sflag instead of-tto specify the source pane.In modern
tmux break-pane,-s src-panespecifies the source pane to break out, while-t dst-windowspecifies the destination window (optional; if omitted, a new window is created). The current code passespaneIdwith-t, which targets the wrong thing. Switch to-s:public async breakPane(paneId: string): Promise<void> { - await this.runTmux(["break-pane", "-t", paneId]); + await this.runTmux(["break-pane", "-s", paneId]); }📝 Committable suggestion