Skip to content

fix: Handle None for replace field in ReplaceColOp schema#1379

Draft
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/replace-col-op-none-validation
Draft

fix: Handle None for replace field in ReplaceColOp schema#1379
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/replace-col-op-none-validation

Conversation

@sentry

@sentry sentry Bot commented May 25, 2026

Copy link
Copy Markdown

This PR addresses issue DALGO-BACKEND-2B3, where a ValueError occurred during the validation of 'replace' operations. The root cause was a mismatch between the frontend sending None for the replace field (to signify replacing with an empty string) and the backend's Pydantic schema ReplaceColOp expecting a non-nullable str.

The fix updates the ReplaceColOp schema in ddpui/schemas/dbt_workflow_schema.py to make the replace field Optional[str] with a default value of an empty string (""). This allows None values from the frontend to be correctly processed, preventing the validation error.

Fixes DALGO-BACKEND-2B3

@sentry

sentry Bot commented May 25, 2026

Copy link
Copy Markdown
Author

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.66%. Comparing base (75cb6fd) to head (27a1bea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1379   +/-   ##
=======================================
  Coverage   58.66%   58.66%           
=======================================
  Files         132      132           
  Lines       15690    15690           
=======================================
  Hits         9205     9205           
  Misses       6485     6485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants